Replace fetcherName with Identifier-based Web Search#10391
Merged
koppor merged 6 commits intoJabRef:mainfrom Sep 22, 2023
Merged
Replace fetcherName with Identifier-based Web Search#10391koppor merged 6 commits intoJabRef:mainfrom
koppor merged 6 commits intoJabRef:mainfrom
Conversation
Siedlerchr
reviewed
Sep 17, 2023
| CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences()); | ||
| parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query))); | ||
| fetcherName = compositeIdFetcher.getName(); | ||
| fetcherName = "Identifier-based Web Search"; |
Member
There was a problem hiding this comment.
Would be great to have this localized as well
Member
There was a problem hiding this comment.
Self-directed learning comment: https://devdocs.jabref.org/code-howtos/localization.html
Direct comment: You forgot to put Localization.lang(...) around. JabRef has no magic to determine translation strings.
koppor
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/230.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)