Change the popup to enter types to the combo box for custom entry types#10912
Merged
calixtus merged 4 commits intoJabRef:mainfrom Feb 25, 2024
Merged
Change the popup to enter types to the combo box for custom entry types#10912calixtus merged 4 commits intoJabRef:mainfrom
calixtus merged 4 commits intoJabRef:mainfrom
Conversation
Disable the add field button if the entry type is not selected to prevent exceptions
Member
Author
|
My PR failed in the unit tests. Should I update the unit tests to be compatible with the modification? |
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
previously approved these changes
Feb 24, 2024
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the improvement
LoayGhreeb
force-pushed
the
fix-for-issue-10560-task3
branch
from
d1e7ba9 to
ce3ca53
Compare
Member
Author
|
Apologies for the confusion, merged the main by mistake |
Member
|
No problem and often a good way to resolve conflicts early on
In end all commits are squashed together
|
Siedlerchr
approved these changes
Feb 25, 2024
calixtus
approved these changes
Feb 25, 2024
Member
Author
|
@Siedlerchr, I want to add this change to the changelog file, I forgot to add it.
|
calixtus
added a commit
that referenced
this pull request
Feb 26, 2024
Member
|
Fixed it. |
Siedlerchr
added a commit
to shawn-jj/jabref
that referenced
this pull request
Feb 26, 2024
* upstream/main: (22 commits) Bump com.github.andygoossens.modernizer from 1.9.0 to 1.9.2 (JabRef#10922) Bump com.dlsc.gemsfx:gemsfx from 1.97.0 to 2.0.3 (JabRef#10923) Bump org.apache.logging.log4j:log4j-to-slf4j from 2.22.1 to 2.23.0 (JabRef#10921) Added missing changelog entry for JabRef#10912 Change the popup to enter types to the combo box for custom entry types (JabRef#10912) Add JDK EA build (JabRef#10904) Fix Broken Links (JabRef#10899) Add HTML2MD conversion to abstract and comment fields (JabRef#10896) docs: Fixed URLs and corrected typos (JabRef#10900) Add refresh button for LaTeX citations. (JabRef#10901) Farewell btut 👋 (JabRef#10905) Fix: About OOError, Alternatives section not visible (JabRef#10902) Update code-quality.md Fix documentation issues: Sourcegraph URL and method name (JabRef#10898) Removed mainapplication layer (JabRef#10895) Update check-links.yml (JabRef#10897) [WIP] Adds the ability to specify [camelN] as a title-related field marker for citation key generation (JabRef#10772) Bump com.dlsc.gemsfx:gemsfx from 1.92.0 to 1.97.0 (JabRef#10894) Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.6.3 to 2.6.4 (JabRef#10892) Bump org.junit.platform:junit-platform-launcher from 1.10.1 to 1.10.2 (JabRef#10893) ... # Conflicts: # src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented task 3 from #10560.
Disabled the add field button if the entry type is not selected to prevent exceptions.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)