Skip to content

Add vector module#11532

Merged
Siedlerchr merged 8 commits intomainfrom
vector-api
Aug 1, 2024
Merged

Add vector module#11532
Siedlerchr merged 8 commits intomainfrom
vector-api

Conversation

@calixtus
Copy link
Copy Markdown
Member

@calixtus calixtus commented Jul 24, 2024

Fixed #11502

Tradeoff: Displays a warning now "Using incubator modules: jdk.incubator.vector"

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Copy Markdown
Member

Needs to be adjusted on the mac pipelines as well

@Siedlerchr
Copy link
Copy Markdown
Member

Have you tested the build?

@calixtus
Copy link
Copy Markdown
Member Author

Windows portable, yes. Works fine.

@Siedlerchr
Copy link
Copy Markdown
Member

Needs to be added here with --add modules

--java-options --add-opens=javafx.controls/javafx.scene.control=org.jabref \
--java-options --add-opens=javafx.controls/com.sun.javafx.scene.control=org.jabref

and in other deployment pipeline as well

@calixtus
Copy link
Copy Markdown
Member Author

Ok I see, will look into it. Thought gradle pipeline was used for GitHub actions.

@calixtus calixtus marked this pull request as draft July 25, 2024 14:54
@Siedlerchr
Copy link
Copy Markdown
Member

Ok I see, will look into it. Thought gradle pipeline was used for GitHub actions.

Yes but not for mac

@calixtus calixtus marked this pull request as ready for review August 1, 2024 10:20
@calixtus calixtus requested a review from Siedlerchr August 1, 2024 10:20
@calixtus
Copy link
Copy Markdown
Member Author

calixtus commented Aug 1, 2024

@Siedlerchr please test if this works on Mac.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: search dev: performance labels Aug 1, 2024
@stephanlukasczyk
Copy link
Copy Markdown
Contributor

Just installed https://builds.jabref.org/pull/11532/merge/JabRef-5.16-arm64.dmg on an MBP with M3 Pro CPU (macOS 14.5). Starting causes macOS to complain that the program is not signed (probably expected) but then nothing happens. JabRef does not show any reactions, it's not starting up. Unfortunately, I do not have the time to dig deeper into it today, sorry.

@Siedlerchr
Copy link
Copy Markdown
Member

Siedlerchr commented Aug 1, 2024

@stephanlukasczyk you have to allow it under settings-> data protection and security (scroll down to the end)
or alternatively xattr -r -d com.apple.quarantine /path/to/MyApp.app

@stephanlukasczyk
Copy link
Copy Markdown
Contributor

@Siedlerchr No, setting xattr -r -d com.apple.quarantine /Applications/JabRef.app does not change anything, still no reaction.

@Siedlerchr
Copy link
Copy Markdown
Member

Yeah, starting it manually I get java.lang.module.FindException: Module jdk.incubator.vector not found
/Applications/JabRef.app/Contents/MacOS/JabRef
if I remove it from app.cfg it starts again

@Siedlerchr
Copy link
Copy Markdown
Member

Fixed it, we need it as jpackage option and as start option

@Siedlerchr Siedlerchr closed this Aug 1, 2024
@Siedlerchr Siedlerchr reopened this Aug 1, 2024
@Siedlerchr Siedlerchr enabled auto-merge August 1, 2024 19:24
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit efccc7e Aug 1, 2024
@Siedlerchr Siedlerchr deleted the vector-api branch August 1, 2024 19:48
@calixtus
Copy link
Copy Markdown
Member Author

calixtus commented Aug 1, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: search dev: performance status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance indexing speed with java vector api

3 participants