Conversation
| // in case of an error, propagate the error message | ||
| SimpleHttpResponse httpResponse = new SimpleHttpResponse(httpURLConnection); | ||
| LOGGER.info("{}", httpResponse); | ||
| LOGGER.info("{}: {}", this.source, httpResponse); |
There was a problem hiding this comment.
This will leak api keys? I remember that we had an issue about this
|
WTF, one needs to enable TLS 1.2 manually?! -- implemented at 0f3b387 |
|
According to https://de.wikipedia.org/wiki/Transport_Layer_Security it should matter if TLS 1.2 or TLS 1.3. I saw a green test "fullTextFoundByDOI" at ResearchGateTest. But only once 😥. |
|
Note sure if we really need it - https://stackoverflow.com/a/73097062/873282 - but that I saw the green test... Not sure how to proceed. I would keep this change and see if there are any changes (to the better or to the worse). The other alternative is to check which protocols are used etc. |
| */ | ||
| public static void setSSLVerification(SSLSocketFactory socketFactory, HostnameVerifier verifier) { | ||
| try { | ||
| HttpsURLConnection.setDefaultSSLSocketFactory(socketFactory); |
There was a problem hiding this comment.
I think this will have an impact of using custom SSL certifactes now
There was a problem hiding this comment.
I checked. --> TrustStore is created at org.jabref.logic.net.ssl.TrustStoreManager#configureTrustStore.
I created JavaDoc for it: 300b7b3
There was a problem hiding this comment.
Ah, maybe, this only works if we do this setting?! - I am not sure. How can we test this?
There was a problem hiding this comment.
From what I see it should be enough if we set in the truststore manager
There was a problem hiding this comment.
I was about to revert the change ^^. -- Since its an alpha, we can take the risk?
|
can you take a look at the bvb fetcher? java.lang.IllegalArgumentException: Expected authority at index 8: https:// |
| .withField(StandardField.AUTHOR, "Bloch, Joshua") | ||
| .withField(StandardField.TITLEADDON, "Joshua Bloch") | ||
| .withField(StandardField.EDITION, "3. Auflage, Übersetzung der englischsprachigen 3. Originalausgabe 2018") | ||
| .withField(StandardField.FILE, "ParsedFileField{description='', link='http://search.ebscohost.com/login.aspx?direct=true&scope=site&db=nlebk&db=nlabk&AN=1906353', fileType='PDF'}") |
There was a problem hiding this comment.
Better use withFiles(List.of(new LInkedFile(
koppor
added
the
status: ready-for-review
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
2 participants
This updates the user agent to the latest one by FireFox (source: https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox)
This also logs the URL used for an error HTTP response.
Example:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)