Skip to content

change rename strings#12587

Merged
Siedlerchr merged 5 commits intoJabRef:mainfrom
MhammedAhmmed:fix-12566
Mar 7, 2025
Merged

change rename strings#12587
Siedlerchr merged 5 commits intoJabRef:mainfrom
MhammedAhmmed:fix-12566

Conversation

@MhammedAhmmed
Copy link
Copy Markdown
Contributor

Fix #12566

1- Change "Rename file to a given name" to "Rename files to configured filename format pattern" in entry editor to match Cleaup entries.
2- Fix inconsistencies in Cleaup entries view.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Previous entry editor:
editorPrevious

Current entry editor:
bandicam 2025-03-01 01-38-44-751 - frame at 0m5s

Previous Cleanup entries:
CleanupPrevoius

Current Cleanup entries:
photo_2025-03-01_14-41-35

The text changes in CleanupPresetPanel.fxml & JabRef_en.properties aren’t reflecting in the UI unless I manually set the text using setText in CleanupPresetPanel.java. The photo I attached shows the current Cleanup entries after using setText. After removing it (as it was not needed), I tried rebuilding the project and invalidating the cache, but I'm unsure if the changes will reflect for others.

This what I mean. But now this does not exist as it was not needed.
image

@Siedlerchr Siedlerchr changed the title Fix 12566 change rename strings Mar 2, 2025
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 2, 2025
@Siedlerchr
Copy link
Copy Markdown
Member

Please add a changelog entry

@Siedlerchr
Copy link
Copy Markdown
Member

Siedlerchr commented Mar 2, 2025

This is how it looks for me:

grafik

@subhramit subhramit added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Mar 3, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 7, 2025
Merged via the queue into JabRef:main with commit ae704ae Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make strings consistent

4 participants