First part for implementaion of a Europe PMC fetcher#13389
Merged
Siedlerchr merged 6 commits intomainfrom Jun 22, 2025
Merged
Conversation
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jablib/src/test/java/org/jabref/logic/importer/fetcher/EuropePmcFetcherTest.java
Show resolved
Hide resolved
jablib/src/test/java/org/jabref/logic/importer/fetcher/EuropePmcFetcherTest.java
Show resolved
Hide resolved
koppor
requested changes
Jun 22, 2025
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Small nitpick - otherwise, it looks good.
I would add a CHANGELOG.md entry nevertheless. - We can update it if the feature is updated before the next release.
jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java
Outdated
Show resolved
Hide resolved
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Jun 22, 2025
|
|
||
| // Handle URL | ||
| if (result.has("pmid")) { | ||
| entry.setField(StandardField.URL, "https://pubmed.ncbi.nlm.nih.gov/" + result.getString("pmid") + "/"); |
Member
There was a problem hiding this comment.
Interesting - Normally our maintable should handle this similar to DOI handling.
OK for now, noted down for future work 😋
koppor
reviewed
Jun 22, 2025
| - We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189) | ||
| - We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842) | ||
| - We added the field `monthfiled` to the default list of fields to resolve BibTeX-Strings for [#13375](https://github.com/JabRef/jabref/issues/13375) | ||
| - We added a new ID based fetcher for [EuropePMC](https://europepmc.org/). [#13389](https://github.com/JabRef/jabref/pull/13389) |
Member
There was a problem hiding this comment.
Does this also work with the new entry dialog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/955
Implemented ID based fetcher for EuropePMC
Follow up tasks (new issue):
(That's why I think it's not worth adding it in changelog right now)
Steps to test
Test written
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)