Add Unpaywall fetcher and add JabKit commands for citations#14340
Merged
Add Unpaywall fetcher and add JabKit commands for citations#14340
Conversation
This reverts commit 1fc12a7.
- entry point: JabKitLauncher - command "jabkit": JabKit
- some alphabetical sorting - refine comments - some null markers - some variable name tweaks
…0' into add-cites-citing
Siedlerchr
previously approved these changes
Nov 17, 2025
Member
|
/home/runner/work/jabref/jabref/jablib/src/main/java/org/jabref/logic/importer/fetcher/CustomizableKeyFetcher.java:5: error: cannot find symbol |
Siedlerchr
previously approved these changes
Nov 17, 2025
Siedlerchr
reviewed
Nov 17, 2025
| /// Fetcher for <https://unpaywall.org/> | ||
| /// | ||
| /// Currently only used for storing an "API key" to be able to cope with URLs appearing at web server answers such as `Paper or abstract available at https://api.unpaywall.org/v2/10.47397/tb/44-3/tb138kopp-jabref?email=<INSERT_YOUR_EMAIL>` | ||
| public class UnpaywallFetcher implements SearchBasedFetcher, CustomizableKeyFetcher, FulltextFetcher { |
Member
There was a problem hiding this comment.
Add getTestUrl for api key check, see e.g. MedlineFetcher
Member
|
Have you checked if this work with this check in the ui? |
Member
Author
Siedlerchr
approved these changes
Nov 18, 2025
2 tasks
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
…4340) * Revert "Update Gradle Wrapper from 9.3.0-jabref-1 to 9.1.0 (JabRef#14033)" This reverts commit 1fc12a7. * Clean up packages in JabKit * Fix namings - entry point: JabKitLauncher - command "jabkit": JabKit * First GetCitedWorks * Add some NonNull annotations * Fix main class name * Fix option * Add initial support for unpaywall downloads - some alphabetical sorting - refine comments - some null markers - some variable name tweaks * Fix alphabetical ordering * No default email for Unpaywall * Other handling of Unpaywall * Handle empty key * Fix key customization * Revert changes of gradlew and gradlew.bat * Make UnpayWallFetcher a WebFetcher * Add CHANGELOG.md line * Add commands * Revert "Merge branch 'revert-14033-gradlew-update-9.1.0' into add-cites-citing" This reverts commit ab02d15, reversing changes made to 403910e. * Add links to CHANGELOG.md * Discard changes to .github/workflows/binaries.yml * Fix import * Fix imports * Fix formatting * Fix typo * Fix test * Add getTestUrl() * Swap methods * Fix typo * Fix formatting * Adapt tests to new behavior --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This adds our citation feature to JabKit
Moreover, adds Unpaywall fulltext fetcher.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)