Conversation
- Fix method names in the interface
Siedlerchr
reviewed
Nov 20, 2025
| } | ||
|
|
||
| private enum Provider { | ||
| crossref, |
Member
There was a problem hiding this comment.
enum values should be UPPERCASE
Member
Author
There was a problem hiding this comment.
I wasn't sure if it works with picocli
./gradlew :jabkit:run --args="get-cited-works --provider=semanticscholar --porcelain 10.47397/tb/44-3/tb138kopp-jabref"
Invalid value for option '--provider': expected one of [CROSSREF, SEMANTICSCHOLAR] (case-sensitive) but was 'semanticscholar'
Fixed in f5544da - 39 lines of code ^^
Siedlerchr
reviewed
Nov 20, 2025
| import org.jabref.model.entry.field.StandardField; | ||
| import org.jabref.model.entry.identifier.DOI; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; |
Member
There was a problem hiding this comment.
tools.jackson to avoid the same issue as in the Unpaywall fetcher
1 task
Siedlerchr
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of CrossRef's capability to fetch citation information
Example: https://api.crossref.org/works/10.47397/tb/44-3/tb138kopp-jabref
Not wired into the GUI for our citations tab. This can be a good-first-issue as follow-up.
Steps to test
Alternatively, run
org.jabref.logic.importer.fetcher.citation.crossref.CrossRefCitationFetcherTestMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)