Conversation
- Use JabRefException instead of customized IOExceptions - Refine conditions for actions - Some code reformatting
- enable changing git username and pat in Network Preferences - rename "passwort" to "pat" - adapt casing of headings in Network Preferences
Siedlerchr
reviewed
Dec 3, 2025
| .filter(context -> context.getLocation() == DatabaseLocation.LOCAL) | ||
| .map(context -> | ||
| context.getDatabasePath() | ||
| .flatMap(path -> Injector.instantiateModelOrService(GitHandlerRegistry.class) |
Member
There was a problem hiding this comment.
This really looks hacky here, is there no better way?
Member
Author
There was a problem hiding this comment.
It was in the old code already... I can take a look later.
Member
Author
There was a problem hiding this comment.
Could lead to 50+ changes, because of passing through all it and handling it in StateManager probably. This cache is a global variable for the GUI.
Member
Author
There was a problem hiding this comment.
Could lead to 50+ changes, because of passing through all it and handling it in StateManager probably. This cache is a global variable for the GUI.
Member
There was a problem hiding this comment.
then just fix the faling tests checkstyle
Siedlerchr
previously approved these changes
Dec 3, 2025
Siedlerchr
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the git credentials are only availble when connecting to GitHub. To re-use an existing connection, one needs to configure git credentials somehow. This PR does it.
Follow-up:
Steps to test
gg.cmd just run-pr xyz)Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)