Create Response Model Classes

jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/opencitations/CitationItem.java

@@ -3,77 +3,22 @@
 import java.util.Optional;
 
 import com.google.gson.annotations.SerializedName;
+import org.jspecify.annotations.Nullable;
 
-public class CitationItem {
-    private String oci;
-    private String citing;
-    private String cited;
-    private String creation;
-    private String timespan;
+class CitationItem {
+    @Nullable String oci;
+    @Nullable String citing;
+    @Nullable String cited;
+    @Nullable String creation;
+    @Nullable String timespan;
 
     @SerializedName("journal_sc")
-    private String journalSelfCitation;
+    @Nullable String journalSelfCitation;
 
     @SerializedName("author_sc")
-    private String authorSelfCitation;
+    @Nullable String authorSelfCitation;
 
-    public String getOci() {
-        return oci;
-    }
-
-    public void setOci(String oci) {
-        this.oci = oci;
-    }
-
-    public String getCiting() {
-        return citing;
-    }
-
-    public void setCiting(String citing) {
-        this.citing = citing;
-    }
-
-    public String getCited() {
-        return cited;
-    }
-
-    public void setCited(String cited) {
-        this.cited = cited;
-    }
-
-    public String getCreation() {
-        return creation;
-    }
-
-    public void setCreation(String creation) {
-        this.creation = creation;
-    }
-
-    public String getTimespan() {
-        return timespan;
-    }
-
-    public void setTimespan(String timespan) {
-        this.timespan = timespan;
-    }
-
-    public String getJournalSelfCitation() {
-        return journalSelfCitation;
-    }
-
-    public void setJournalSelfCitation(String journalSelfCitation) {
-        this.journalSelfCitation = journalSelfCitation;
-    }
-
-    public String getAuthorSelfCitation() {
-        return authorSelfCitation;
-    }
-
-    public void setAuthorSelfCitation(String authorSelfCitation) {
-        this.authorSelfCitation = authorSelfCitation;
-    }
-
-    public Optional<String> extractDoi(String pidString) {
+    Optional<String> extractDoi(@Nullable String pidString) {
         if (pidString == null || pidString.isEmpty()) {
             return Optional.empty();
         }
@@ -87,11 +32,11 @@ public Optional<String> extractDoi(String pidString) {
         return Optional.empty();
     }
 
-    public Optional<String> getCitingDoi() {
+    Optional<String> citingDoi() {
         return extractDoi(citing);
     }
 
-    public Optional<String> getCitedDoi() {
+    Optional<String> citedDoi() {
         return extractDoi(cited);
     }
 }

jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/opencitations/CountResponse.java

@@ -1,17 +1,14 @@
 package org.jabref.logic.importer.fetcher.citation.opencitations;
 
-public class CountResponse {
-    private String count;
+import org.jspecify.annotations.Nullable;
 
-    public String getCount() {
-        return count;
-    }
-
-    public void setCount(String count) {
-        this.count = count;
-    }
+class CountResponse {
+    @Nullable String count;
 
-    public int getCountAsInt() {
+    int countAsInt() {
+        if (count == null) {
+            return 0;
+        }
         try {
             return Integer.parseInt(count);
         } catch (NumberFormatException e) {