Smooth shutdown by tobiasdiez · Pull Request #4109 · JabRef/jabref

tobiasdiez · 2018-06-06T14:32:42Z

I tried to remove the System.exit call so that JabRef shutdown smoothly. However, currently an AWT-thread does not want to exit. In order to solve this problem, I removed most calls that would init the AWT toolkit. This includes:

Use JavaFX clipboard instead of AWT
Remove L&F and font customization

Moreover, the Azure telemetry SDK has a bug microsoft/ApplicationInsights-Java#662 that prevents certain threads from terminating. I added the workaround mentioned in this issue.

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

stefan-kolb

Looks good so far. I just added some comments that came to my mind.

stefan-kolb · 2018-06-06T17:37:10Z

src/main/java/org/jabref/JabRefGUI.java

-            }
+        // On Linux, Java FX fonts look blurry per default. This can be improved by using a non-default rendering
+        // setting. See https://github.com/woky/javafx-hates-linux
+        if (Globals.prefs.getBoolean(JabRefPreferences.FX_FONT_RENDERING_TWEAK)) {


Is there a Linux switch anywhere?

Yes, it is turned on by default only on Linux: defaults.put(FX_FONT_RENDERING_TWEAK, OS.LINUX);

stefan-kolb · 2018-06-06T17:40:24Z

src/main/java/org/jabref/gui/ClipBoardManager.java

+public class ClipBoardManager {

    private static final Logger LOGGER = LoggerFactory.getLogger(ClipBoardManager.class);
+    public static final DataFormat XML = new DataFormat("application/xml");


Is this used anywhere?

Yes, when we put xml in the clipboard (which may happen for copied citation styles)

We have already a class DragAndDropDataFormats, maybe you could rename that and add it to the collection?

I don't want to interfere with your PR (especially, since I think it might completely remove the DragAndDropFormats class or make it internal to the DragAndDropManager).

stefan-kolb · 2018-06-06T17:43:35Z

src/main/java/org/jabref/gui/actions/CopyVersionToClipboardAction.java

-import org.jabref.logic.l10n.Localization;
-import org.jabref.logic.util.BuildInfo;
-
-public class CopyVersionToClipboardAction extends AbstractAction {


Functionality totally removed?

There is still a "copy version" button in the about dialog but no separate menu entry. (I didn't change anything as part of this PR; this class was completely unused).

stefan-kolb · 2018-06-06T17:45:44Z

src/test/java/org/jabref/gui/ClipBoardManagerTest.java

-
-public class ClipBoardManagerTest {
-
-    private ClipBoardManager clipBoardManager;


What about the tests?

The clipboard manager needs to run on the JavaFX thread to work, which is not easily achieved in a test. Thus, deleting these tests was easier than trying to rewrite them ;-)

Siedlerchr · 2018-06-06T19:46:10Z

I created a branch from master, cherry picked 39e30cc, and deleted all system.exit() calls.
It works fine for me. For reference, I have created a PR to show the diff: #4111

stefan-kolb

So we use this insetad of the PR of Christoph?!

stefan-kolb · 2018-06-13T06:31:12Z

src/main/java/org/jabref/Globals.java

+            client.trackSessionState(SessionState.End);
+            client.flush();
+
+            // Workaround for bug https://github.com/Microsoft/ApplicationInsights-Java/issues/662


Add FIXME so we can revert this after they merged the bug fix.

I really would use my PR as a base. As this done does more than the initial necessary solution.

I don't understand the complication (including merge conflicts) but well it doesn't really matter. @Siedlerchr @stefan-kolb can I merge this PR?

Siedlerchr · 2018-06-14T10:23:11Z

Your PR caused this error now

 java.lang.ExceptionInInitializerError
        at org.jabref.gui.fieldeditors.LinkedFileViewModelTest.setUp(LinkedFileViewModelTest.java:55)
        Caused by:
        java.lang.IllegalStateException: This operation is permitted on the event thread only; currentThread = Test worker
            at com.sun.glass.ui.Application.checkEventThread(Application.java:443)
            at com.sun.glass.ui.ClipboardAssistance.<init>(ClipboardAssistance.java:40)
            at com.sun.javafx.tk.quantum.QuantumToolkit.getSystemClipboard(QuantumToolkit.java:1200)
            at javafx.scene.input.Clipboard.getSystemClipboardImpl(Clipboard.java:413)
            at javafx.scene.input.Clipboard.getSystemClipboard(Clipboard.java:178)
            at org.jabref.gui.ClipBoardManager.<init>(ClipBoardManager.java:41)
            at org.jabref.Globals.<clinit>(Globals.java:57)
            ... 1 more

https://travis-ci.org/JabRef/jabref/jobs/392180785

Siedlerchr · 2018-06-14T10:27:56Z

And removing setting the font size without providing an alternative was not the good idea!

stefan-kolb · 2018-06-14T11:21:04Z

Just revert If necessary. Christoph <notifications@github.com> schrieb am Do., 14. Juni 2018, 12:28:

…

And removing setting the font size without providing an alternative was not the good idea! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4109 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCtQ3fuo3W04385wQK074uTX3G36Wgeks5t8jqwgaJpZM4UcxAw> .

tobiasdiez · 2018-06-14T13:05:04Z

Sorry, I was so used to failing tests against the maintable-branch that I ignored the red travis icon. Tests are now fixed in master.

tobiasdiez added 4 commits June 6, 2018 15:56

Replace swing clipboard with JavaFX one

46d4de8

Properly shutdown JabRef (not with System.exit)

78676fa

Remove Swing stuff (L&F, font customization)

7416369

Code cleanup

3304167

stefan-kolb reviewed Jun 6, 2018

View reviewed changes

tobiasdiez added 2 commits June 6, 2018 21:06

Properly shutdown telemetry client

39e30cc

Don't run on Swing thread

2c0ed8f

tobiasdiez mentioned this pull request Jun 6, 2018

[WIP] Split push to applications in logic and gui #4110

Merged

6 tasks

tobiasdiez changed the title ~~[WIP] Smooth shutdown~~ Smooth shutdown Jun 6, 2018

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 6, 2018

tobiasdiez mentioned this pull request Jun 7, 2018

Fix open thread prevents shutdown #4111

Merged

6 tasks

stefan-kolb reviewed Jun 13, 2018

View reviewed changes

Merge branch 'master' into smoothShutdown

7ab876e

tobiasdiez merged commit 70e9734 into master Jun 13, 2018

tobiasdiez deleted the smoothShutdown branch June 13, 2018 16:04

tobiasdiez mentioned this pull request Jul 7, 2018

Make global font size customizable #4178

Merged

6 tasks

koppor mentioned this pull request Mar 8, 2020

Shutdown should be fixed since v2.1.2 #5993

Merged


		public class ClipBoardManagerTest {

		private ClipBoardManager clipBoardManager;

Uh oh!

Conversation

tobiasdiez commented Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefan-kolb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefan-kolb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Jun 14, 2018

Uh oh!

stefan-kolb commented Jun 14, 2018 via email

Uh oh!

tobiasdiez commented Jun 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tobiasdiez commented Jun 6, 2018 •

edited

Loading

Siedlerchr commented Jun 6, 2018 •

edited

Loading

Siedlerchr commented Jun 14, 2018 •

edited

Loading