Fix #5939 by creating a mutable list in OpenDatabaseAction#5940
Merged
Siedlerchr merged 1 commit intoJabRef:masterfrom Feb 12, 2020
Merged
Fix #5939 by creating a mutable list in OpenDatabaseAction#5940Siedlerchr merged 1 commit intoJabRef:masterfrom
Siedlerchr merged 1 commit intoJabRef:masterfrom
Conversation
Siedlerchr
requested changes
Feb 12, 2020
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
Thanks for the fix! Just a little suggestion to simplify the code.
src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java
Outdated
Show resolved
Hide resolved
Ka0o0
force-pushed
the
fix-5939-file-history-exception
branch
from
d0f5263 to
6746a9b
Compare
Siedlerchr
approved these changes
Feb 12, 2020
Member
|
Thanks again for your contribution! 👍 |
Member
|
We tried it locally. Did not fix the issue. We will switch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem when opening a library from the recent libraries menu. fixes #5939