Add graal info to module file by tobiasdiez · Pull Request #6010 · JabRef/jabref

tobiasdiez · 2020-02-24T16:36:31Z

As mentioned by @michel-kraemer in https://github.com/JabRef/jabref#issuecomment-590334280 the error might result from a non-present module description. Not sure if the one I took covers everything. (@michel-kraemer do you remember what to add exactly?)

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for bigger UI changes)
Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

…ava mode

Siedlerchr · 2020-02-24T18:32:47Z

/home/runner/work/jabref/jabref/src/main/java/module-info.java:67: error: module not found: org.graalvm.js.scriptengine

requires transitive org.graalvm.js.scriptengine;

Siedlerchr · 2020-02-25T07:44:16Z

Still no sucess:

Btw, you can directly test this locally if you just call gradlew jlink and then run it from the bat

java.lang.Exception: java.lang.InternalError: java.lang.IllegalAccessException: class com.oracle.truffle.api.impl.DefaultTruffleRuntime$Loader (in module org.graalvm.truffle) cannot access class jdk.vm.ci.services.Services (in module jdk.internal.vm.ci) because module jdk.internal.vm.ci does not export jdk.vm.ci.services to module org.graalvm.truffle
        at org.jabref.gui.util.DefaultTaskExecutor.convertToException(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.util.DefaultTaskExecutor.lambda$getJavaFXTask$4(Unknown Source) ~[org.jabref:?]
        at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.event.EventUtil.fireEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at javafx.event.Event.fireEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at javafx.concurrent.EventHelper.fireEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at javafx.concurrent.Task.fireEvent(Unknown Source) ~[org.jabref.merged.module:?]
        at javafx.concurrent.Task.setState(Unknown Source) ~[org.jabref.merged.module:?]
        at javafx.concurrent.Task$TaskCallable.lambda$call$2(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source) ~[org.jabref.merged.module:?]
        at java.security.AccessController.doPrivileged(Unknown Source) ~[?:?]
        at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source) ~[org.jabref.merged.module:?]
        at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) ~[org.jabref.merged.module:?]
        at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source) ~[org.jabref.merged.module:?]
        at java.lang.Thread.run(Unknown Source) [?:?]
Caused by: java.lang.InternalError: java.lang.IllegalAccessException: class com.oracle.truffle.api.impl.DefaultTruffleRuntime$Loader (in module org.graalvm.truffle) cannot access class jdk.vm.ci.services.Services (in module jdk.internal.vm.ci) because module jdk.internal.vm.ci does not export jdk.vm.ci.services to module org.graalvm.truffle
        at com.oracle.truffle.api.impl.DefaultTruffleRuntime$Loader.load(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.DefaultTruffleRuntime.getCapability(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.TruffleLocator.loaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.Accessor.loaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.EngineAccessor.allLoaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.LanguageCache.createLanguages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.LanguageCache.languages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.languages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.initializeLanguages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.<init>(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.<init>(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotImpl.buildEngine(Unknown Source) ~[org.graalvm.truffle:?]
        at org.graalvm.polyglot.Engine$Builder.build(Unknown Source) ~[org.graalvm.sdk:?]
        at org.graalvm.polyglot.Context$Builder.build(Unknown Source) ~[org.graalvm.sdk:?]
        at de.undercouch.citeproc.script.GraalScriptRunner.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.script.ScriptRunnerFactory.createGraalRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.script.ScriptRunnerFactory.createRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.getRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at org.jabref.logic.citationstyle.CSLAdapter.initialize(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CSLAdapter.makeBibliography(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitations(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitation(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStylePreviewLayout.generatePreview(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.preview.PreviewViewer.lambda$update$3(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.util.BackgroundTask$1.call(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.util.DefaultTaskExecutor$1.call(Unknown Source) ~[org.jabref:?]
        at javafx.concurrent.Task$TaskCallable.call(Unknown Source) ~[org.jabref.merged.module:?]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:?]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?]
        ... 1 more
Caused by: java.lang.IllegalAccessException: class com.oracle.truffle.api.impl.DefaultTruffleRuntime$Loader (in module org.graalvm.truffle) cannot access class jdk.vm.ci.services.Services (in module jdk.internal.vm.ci) because module jdk.internal.vm.ci does not export jdk.vm.ci.services to module org.graalvm.truffle
        at jdk.internal.reflect.Reflection.newIllegalAccessException(Unknown Source) ~[?:?]
        at java.lang.reflect.AccessibleObject.checkAccess(Unknown Source) ~[?:?]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
        at com.oracle.truffle.api.impl.DefaultTruffleRuntime$Loader.load(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.DefaultTruffleRuntime.getCapability(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.TruffleLocator.loaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.api.impl.Accessor.loaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.EngineAccessor.allLoaders(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.LanguageCache.createLanguages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.LanguageCache.languages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.languages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.initializeLanguages(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.<init>(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotEngineImpl.<init>(Unknown Source) ~[org.graalvm.truffle:?]
        at com.oracle.truffle.polyglot.PolyglotImpl.buildEngine(Unknown Source) ~[org.graalvm.truffle:?]
        at org.graalvm.polyglot.Engine$Builder.build(Unknown Source) ~[org.graalvm.sdk:?]
        at org.graalvm.polyglot.Context$Builder.build(Unknown Source) ~[org.graalvm.sdk:?]
        at de.undercouch.citeproc.script.GraalScriptRunner.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.script.ScriptRunnerFactory.createGraalRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.script.ScriptRunnerFactory.createRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.getRunner(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at de.undercouch.citeproc.CSL.<init>(Unknown Source) ~[org.jabref.merged.module:?]
        at org.jabref.logic.citationstyle.CSLAdapter.initialize(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CSLAdapter.makeBibliography(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitations(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitation(Unknown Source) ~[org.jabref:?]
        at org.jabref.logic.citationstyle.CitationStylePreviewLayout.generatePreview(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.preview.PreviewViewer.lambda$update$3(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.util.BackgroundTask$1.call(Unknown Source) ~[org.jabref:?]
        at org.jabref.gui.util.DefaultTaskExecutor$1.call(Unknown Source) ~[org.jabref:?]
        at javafx.concurrent.Task$TaskCallable.call(Unknown Source) ~[org.jabref.merged.module:?]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:?]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?]

…hel-kraemer/jabref into graal * 'citeproc-java-2.1.0-SNAPSHOT' of https://github.com/michel-kraemer/jabref: Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode

Siedlerchr · 2020-02-26T19:14:24Z

Seems to be a bug in graal which got resolved in 19.3.0: oracle/graal#1751
@michel-kraemer I merged your PR into this branch to test the things with your new snapshot.
Would it be possible to update to the new graal version?
https://github.com/michel-kraemer/citeproc-java/blob/master/citeproc-java/build.gradle#L26

Siedlerchr · 2020-02-26T20:07:51Z

Yippieh, it works now! 🚨 🎉 😀

@michel-kraemer I got it to work, but for one entry it throws the following exception:

21:02:56.890 [JavaFX Application Thread] ERROR org.jabref.gui.preview.PreviewViewer - Error while generating citation style
java.lang.NullPointerException: null
        at de.undercouch.citeproc.csl.internal.rendering.SDate.renderInternal(SDate.java:58) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:38) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:14) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Behavior.lambda$wrap$0(Behavior.java:21) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.rendering.SDate.render(SDate.java:49) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.SRenderingElementContainer.lambda$render$0(SRenderingElementContainer.java:57) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at java.util.ArrayList.forEach(ArrayList.java:1507) ~[?:?]
        at de.undercouch.citeproc.csl.internal.SRenderingElementContainer.render(SRenderingElementContainer.java:57) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.rendering.SText.renderInternal(SText.java:102) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.TextCase.accept(TextCase.java:31) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.TextCase.accept(TextCase.java:17) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Behavior.lambda$wrap$0(Behavior.java:21) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Quotes.accept(Quotes.java:41) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Quotes.accept(Quotes.java:14) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Behavior.lambda$wrap$0(Behavior.java:21) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:38) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:14) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Behavior.lambda$wrap$0(Behavior.java:21) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.rendering.SText.render(SText.java:57) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.SLayout.renderInternal(SLayout.java:43) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:38) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Affixes.accept(Affixes.java:14) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.behavior.Behavior.lambda$wrap$0(Behavior.java:21) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.SLayout.render(SLayout.java:25) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.csl.internal.SBibliography.render(SBibliography.java:66) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.CSL.makeBibliography(CSL.java:1331) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at de.undercouch.citeproc.CSL.makeBibliography(CSL.java:1218) ~[citeproc-java-2.1.0-SNAPSHOT.jar:?]
        at org.jabref.logic.citationstyle.CSLAdapter.makeBibliography(CSLAdapter.java:56) ~[main/:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitations(CitationStyleGenerator.java:56) ~[main/:?]
        at org.jabref.logic.citationstyle.CitationStyleGenerator.generateCitation(CitationStyleGenerator.java:47) ~[main/:?]
        at org.jabref.logic.citationstyle.CitationStylePreviewLayout.generatePreview(CitationStylePreviewLayout.java:15) ~[main/:?]
        at org.jabref.gui.preview.PreviewViewer.lambda$update$3(PreviewViewer.ja

For this entry:

@Article{bbbbbbbb,
  author          = {Trapnell, Cole and Pachter, Lior and Salzberg, Steven L.},
  journal         = {2D Materials},
  title           = {{TopHat}: discovering splice junctions with {RNA}-Seq},
  year            = {2009},
  issn            = {1866-0452},
  month           = {mar},
  number          = {9},
  pages           = {1105--1111},
  volume          = {25},
  citation-subset = {IM},
  country         = {Germany},
  created         = {2016-05-06},
  date            = {2016},
  doi             = {10.1093/bbbb/btp120},
  issn-linking    = {1866-0452},
  issue           = {15},
  keywords        = {rank4},
  nlm             = {PMC4860871},
  nlm-id          = {101475967},
  pii             = {arztebl.2016.0261},
  pmc             = {PMC4860871},
  pmid            = {27151464},
  publisher       = {Oxford University Press ({OUP})},
  pubmodel        = {Print},
  pubstatus       = {ppublish},
  revised         = {2016-05-23},
  timestamp       = {2017-07-15},
  url             = {http://www.google.de},
}

Siedlerchr · 2020-02-26T20:16:53Z

All tests performed with ./gradlew jlink
Installer works fine as well

koppor

Some nitpick comment. Works fine here in the portable edition. Love it.

build.gradle

michel-kraemer · 2020-02-27T13:28:29Z

@Siedlerchr

@michel-kraemer I merged your PR into this branch to test the things with your new snapshot.
Would it be possible to update to the new graal version?

Sure. Shouldn't be a larger problem. Do you need it urgently? If so, I can do it on the weekend. If not, I'd prefer to do it on the next weekend after my paper deadline :)

Siedlerchr · 2020-02-27T13:33:30Z

@michel-kraemer As it's working now in general, I don't think it's anylonger necessary to update graal urgently.

michel-kraemer · 2020-02-27T13:51:54Z

@Siedlerchr Great! Let me know if you find bugs in the pure Java implementation. Also, if you need a fixed version (i.e. a beta.1 instead of a SNAPSHOT), just contact me.

Siedlerchr · 2020-02-27T14:16:46Z

@michel-kraemer This entry created an exception #6010 (comment)

And when creating a new entry with empty fields I got an exception as well. I will check later for details again. But also tested with another database and that worked fine so far.

michel-kraemer · 2020-02-27T14:44:50Z

@Siedlerchr May I ask you to create issues in the citeproc-java repo (https://github.com/michel-kraemer/citeproc-java), so we can keep track of the fixes? Thanks!

* upstream/master: Remove "Merge Entries" from Quality Menu (#6021) Raise codecov threshold (#6027) Translation for SpecialField names in preferences (#6031) Fix dependency updates workflow (#6033) Add graal info to module file (#6010) Group remote database actions in menu Move journal abbreviations to quality

koppor · 2020-02-27T08:18:58Z

CHANGELOG.md

 - We fixed an issue where changing entry type doesn't always work when biblatex source is shown. [#5905](https://github.com/JabRef/jabref/issues/5905)
 - We fixed an issue where the group and the link column were not updated after changing the entry in the main table. [#5985](https://github.com/JabRef/jabref/issues/5985)
 - We fixed an issue where reordering the groups was not possible after inserting an article. [#6008](https://github.com/JabRef/jabref/issues/6008)
+- We fixed an issue where citation styles except the default "Preview" could not be used. [#56220](https://github.com/JabRef/jabref/issues/5622)


Isn't the default preview mode based on our export filter capability? See https://docs.jabref.org/setup/preview

I would suggest to remove "except..." or reword to: "citation styles stopped working"

koppor · 2021-01-07T12:21:02Z

src/main/java/module-info.java

+    requires org.graalvm.truffle;
+    requires org.graalvm.sdk;
+    requires transitive org.graalvm.js;
+    requires java.scripting;


I thought that 2.1.0-SNAPSHOT does not require JavaScript anymore (see also michel-kraemer/citeproc-java#92). @tobiasdiez Do you remember why you had to add these dependencies?

9ff3112 Update bibtex.csl (#6021) 68ed5f7 Don't initialize with hyphen in Vancouver/NLM (#6022) 80206ad Update american-physics-society.csl (#5934) cfbdba6 Update csl style (#6003) 546ee88 Update institut-francais-darcheologie-orientale-en.csl (#6018) 1153e3e Update institut-francais-darcheologie-orientale-etudes-arabes.csl (#6019) 42d5031 Update institut-francais-darcheologie-orientale-arab-studies.csl (#6020) 2e10c7a Update institut-francais-darcheologie-orientale.csl (#6015) 0c7d6a1 Create science-china-materials.csl (#6017) 0eb4bc7 Update frontiers.csl (#6014) 0fd9cc2 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5963) 1393837 Update harvard-university-of-the-west-of-england.csl (#6013) 4474b0e Update frontiers-of-biogeography.csl (#6010) 736c6df Render status field (for forthcoming, in press, etc.) to date groups (#6005) 51ff3dc Create journal-of-contemporary-water-research-and-education.csl (#5912) 7387ed3 cell.csl: Add a macro for DOI and webpage accessed date. (#5999) 21e2177 Create respiratory-care-journal.csl (#5998) d0a2846 Update archaeonautica.csl (#5987) 664784e Update cardiff-university-harvard.csl (#5982) 07ce91e improve journal-of-avian-biology.csl (#5984) 349a5d6 update based on latest version of ISO 690 standard (#5976) d8c3725 Update mary-ann-liebert-vancouver.csl (#5981) 7b2e70d Update style-manual-australian-government.csl (#5975) bebf50c Create extracellular-vesicles-and-circulating-nucleic-acids.csl (#5979) cabcdd4 Update united-states-international-trade-commission.csl (#5967) 948c48a Update cardiff-university-harvard.csl (#5977) d6bf535 Add name to label gun cf0d930 Test label gun 2f40fcd Update the-journal-of-egyptian-archaeology.csl (#5964) aa023e1 Create materials-research-society-bulletin.csl (#5917) ea31783 Changed quotation marks to Spanish ones (#5968) 27245f9 AJA: Add "." suffix to citation layout. (#5971) 7726a40 Update american-medical-association.csl (#5970) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 9ff3112

michel-kraemer and others added 2 commits February 22, 2020 18:45

Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-J…

7675383

…ava mode

Add graal info to module file

3f222be

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 24, 2020

Update module-info.java

ba9e971

Siedlerchr added 2 commits February 26, 2020 20:04

Merge branch 'citeproc-java-2.1.0-SNAPSHOT' of https://github.com/mic…

1e3dbb9

…hel-kraemer/jabref into graal * 'citeproc-java-2.1.0-SNAPSHOT' of https://github.com/michel-kraemer/jabref: Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode

Merge branch 'master' into graal

76f8c26

fix loading of CSL styles using correct path

905e9e8

Siedlerchr mentioned this pull request Feb 26, 2020

Try to fix loading of CSL again #6002

Closed

5 tasks

use acm stlye as default

452bef6

koppor reviewed Feb 27, 2020

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

build.gradle Outdated Show resolved Hide resolved

Siedlerchr added 2 commits February 27, 2020 09:02

disbale debug mode

139a749

add changelog entry

dcf1015

Siedlerchr merged commit 3e0284d into master Feb 27, 2020

Siedlerchr deleted the graal branch February 27, 2020 10:07

Siedlerchr mentioned this pull request Feb 27, 2020

Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode #5997

Closed

5 tasks

koppor reviewed Mar 17, 2020

View reviewed changes

koppor mentioned this pull request Aug 2, 2020

Reduce JabRef release size by not bundling WebKit for both Windows and Linux in all installers #6340

Closed

koppor mentioned this pull request Jan 7, 2021

Readd ACM style to csl #7308

Closed

5 tasks

koppor reviewed Jan 7, 2021

View reviewed changes

Uh oh!

Conversation

tobiasdiez commented Feb 24, 2020 • edited by Siedlerchr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Feb 24, 2020

Uh oh!

Siedlerchr commented Feb 25, 2020

Uh oh!

Siedlerchr commented Feb 26, 2020

Uh oh!

Siedlerchr commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michel-kraemer commented Feb 27, 2020

Uh oh!

Siedlerchr commented Feb 27, 2020

Uh oh!

michel-kraemer commented Feb 27, 2020

Uh oh!

Siedlerchr commented Feb 27, 2020

Uh oh!

michel-kraemer commented Feb 27, 2020

Uh oh!

koppor Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

koppor Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tobiasdiez commented Feb 24, 2020 •

edited by Siedlerchr

Loading

Siedlerchr commented Feb 26, 2020 •

edited

Loading

Siedlerchr commented Feb 26, 2020 •

edited

Loading