Sort-in root classes into packages (architecture)#6853
Merged
Conversation
koppor
force-pushed
the
fix-archicture
branch
from
618649b to
fd065c4
Compare
Siedlerchr
reviewed
Sep 2, 2020
|
|
||
| URL url = JabRefMain.class.getResource(STYLES_ROOT + "/acm-siggraph.csl"); | ||
| URL url = CitationStyle.class.getResource(STYLES_ROOT + "/acm-siggraph.csl"); | ||
| Objects.requireNonNull(url); |
Member
There was a problem hiding this comment.
I fear this change will not work. We explicitly need the root path.
Member
|
Don't forget to update the run configuration in the wiki. We maybe also need to check the build.gradle files for the jpackager arguments |
Member
Author
|
Siedlerchr
added a commit
that referenced
this pull request
Sep 4, 2020
koppor
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follw-up to #6825.