Fix could not connect to LO on Mac OSX#6970
Merged
Siedlerchr merged 7 commits intomasterfrom Oct 3, 2020
Merged
Conversation
Siedlerchr
added
the
status: ready-for-review
koppor
requested changes
Oct 3, 2020
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Some nitpicks. Otherwise: LGTM
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with LO 7. Apparently it's necessary to add the "real" soffice dir as well to the UrlClassLoader classpath