Fix cleanup run on wrong entry when fetching from DOI#7675
Merged
Siedlerchr merged 1 commit intomainfrom Apr 29, 2021
Merged
Conversation
Siedlerchr
changed the title
Siedlerchr
added
the
status: ready-for-review
tobiasdiez
requested changes
Apr 28, 2021
Member
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Except the strange changes to what seems to be an unrelated file, this LGTM
| private final PreferencesService preferences; | ||
| private final BibEntryTypesManager entryTypesManager; | ||
|
|
||
| private final ImportCleanup cleanup = new ImportCleanup(BibDatabaseMode.BIBTEX); |
Member
There was a problem hiding this comment.
I guess these were changes from previous commits?
Member
Author
There was a problem hiding this comment.
Somehow my branch was not up to date.
Siedlerchr
added a commit
that referenced
this pull request
May 4, 2021
* upstream/main: (354 commits) Fix ScienceDirect fetcher (#7684) Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697) Update Gradle from 6.8.3 to 7.0 (#7619) Fixes Jabref#7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674) Refactoring existing unit tests (#7693) cover boundary cases & add more unit tests (#7694) Bump classgraph from 4.8.104 to 4.8.105 (#7688) Bump java-diff-utils from 4.9 to 4.10 (#7692) Fix arXiv fetcher tests (#7686) Make key for ScienceDirect configurable (#7683) migration of timestamp (#7671) Fix CCSB and DOAJ (#7426) [Bot] Update CSL styles (#7680) MS Office XML: Export month name (#7677) linkfix (#7678) readd fix (#7675) Fix threading cleanup in performSearch (#7672) add missing changelog delete bug fix (#7580) Add more unit tests to three gui classes (#7636) ... # Conflicts: # build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6267
Cleanup did use the wrong entry
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)