Fix ArXiVIdentifier -- dot is required and not arbitrary character#8149
Merged
Siedlerchr merged 6 commits intomainfrom Oct 17, 2021
Merged
Fix ArXiVIdentifier -- dot is required and not arbitrary character#8149Siedlerchr merged 6 commits intomainfrom
Siedlerchr merged 6 commits intomainfrom
Conversation
tobiasdiez
approved these changes
Oct 15, 2021
Member
tobiasdiez
left a comment
There was a problem hiding this comment.
Ohh, good that you spotted the duplication in the Eprint and Arxiv identifier.
Member
|
A fetcher test is failing: |
Example: Caused by: java.io.IOException: Server returned HTTP response code: 500 for URL: eprint.iacr.org/eprint-bin/cite.pl?entry=2017/1118
Member
Author
|
Tests failing, because IEEE is down: Example link: https://ieeexplore.ieee.org/document/4279612 |
Member
Author
|
checkstyle should be fixed by #8154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In #8129 @colinhex found out that we have a parsing error in
org.jabref.model.entry.identifier.ArXivIdentifier. ArXiV requires a.(dot) and not an arbitrary character. See https://arxiv.org/help/arxiv_identifier.This PR fixes it.
Moreover, I identified that
Eprintis a semantic duplicate ofArXivIdentifier. The former was implemented by @stefan-kolb on 2017-03-09, the latter by @tobiasdiez on 2017-01-15. I removedEprintand integrated the tests inArXivIdentifierTest. I also fixed some minor issues inArXivIdentifier.CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)