Observable Preferences J (Preview) and minor refactor#8370
Conversation
…rded for better understanding
injected other fields
calixtus
added
component: entry-editor
component: entry-preview
component: preferences
status: ready-for-review
|
I don't like the idea of adding the search box below the lists. That's not intuitive. A search bar at the top allows the users to quickly browse through the avaiable styles |
|
Well, I did not like the search box over the full length of both lists, even though the search filter only applies to the available list. |
|
|
| public PreviewPreferences getPreviewPreferences() { | ||
| if (this.previewPreferences == null) { | ||
| updatePreviewPreferences(); | ||
| if (Objects.nonNull(previewPreferences)) { |
There was a problem hiding this comment.
Usage of Objects.nonNull is only useful in predicates/lambdas:
This method exists to be used as a Predicate, filter(Objects::nonNull)
There was a problem hiding this comment.
We already used this method in multiple locations in JabRef and everywhere in the preference conversion complex. For consistency in the code I'd like to continue to use it. The api-note, that this method especially exists for use as a Predicate doesn't mean that it couldn't be used for something else too. 😅
|
I've found some kind of problems with selecting another style. Now select an entry and cycle to the next style with F9, |
|
Further investigation showed: The issue occurs if the Customized Preview style is not the firs tone |
# Conflicts: # src/main/java/org/jabref/gui/collab/EntryAddChangeViewModel.java # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/entryeditor/FieldsEditorTab.java # src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java # src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java # src/main/java/org/jabref/gui/preview/PreviewPanel.java # src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
* upstream/main: Observable Preferences J (Preview) and minor refactor (#8370) quickfix (#8383) Live reloading when switching themes (#7336) FIX NPE on Merge Dialog (#8380) Bump org.eclipse.jgit from 5.13.0.202109080827-r to 6.0.0.202111291000-r (#8378) Bump jackson-dataformat-yaml from 2.13.0 to 2.13.1 (#8379) Bump tika-core from 2.2.0 to 2.2.1 (#8377) Update turabian-fullnote-bibliography-no-ibid.csl Squashed 'buildres/csl/csl-locales/' changes from d5ee85de8e..c38205618f Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..f78c707
2 participants
Follow up to #8336
Preview as a separate tab pref should now have effect without need to restart jabref.
Also moved the search box in the preview panel below the list.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)