Skip to content

Oberservable Preferences M (CleanupPreferences)#9126

Merged
Siedlerchr merged 14 commits intomainfrom
prefs-refactor-cleanups
Sep 3, 2022
Merged

Oberservable Preferences M (CleanupPreferences)#9126
Siedlerchr merged 14 commits intomainfrom
prefs-refactor-cleanups

Conversation

@calixtus
Copy link
Copy Markdown
Member

@calixtus calixtus commented Sep 3, 2022

Follow up to #9065

Will break the global preference settings for the cleanup jobs. User will have to reconfigure!
Migrations added!

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 3, 2022
@koppor
Copy link
Copy Markdown
Member

koppor commented Sep 3, 2022

Tried it locally:

ERROR: Unexpected exception: java.lang.NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "
java.util.Map.get(Object)" is null
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getBooleanDefault(JabRefPreferences.java:882)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getBoolean(JabRefPreferences.java:874)
        at org.jabref@100.0.0/org.jabref.migrations.PreferencesMigrations.upgradeCleanups(PreferencesMigrations.java:482)
        at org.jabref@100.0.0/org.jabref.migrations.PreferencesMigrations.runMigrations(PreferencesMigrations.java:63)
        at org.jabref@100.0.0/org.jabref.gui.JabRefMain.start(JabRefMain.java:98)
        at javafx.graphics@18.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:847)
        at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:484)
        at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
        at javafx.graphics@18.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
        at javafx.graphics@18.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at javafx.graphics@18.0.2/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at javafx.graphics@18.0.2/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
        at java.base/java.lang.Thread.run(Thread.java:833)

@Siedlerchr Siedlerchr added the status: changes-required Pull requests that are not yet complete label Sep 3, 2022
@calixtus calixtus removed the status: changes-required Pull requests that are not yet complete label Sep 3, 2022
@Siedlerchr
Copy link
Copy Markdown
Member

When opening the cleanup dialog INFO: Doing a cleanup for 1 entries.. without having done anything

@Siedlerchr
Copy link
Copy Markdown
Member

Works good so far

@Siedlerchr Siedlerchr merged commit cf6b1ed into main Sep 3, 2022
@Siedlerchr Siedlerchr deleted the prefs-refactor-cleanups branch September 3, 2022 22:25
Siedlerchr added a commit that referenced this pull request Sep 4, 2022
* upstream/main:
  Fix link and remove obsolete FAQ
  Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (#9130)
  Tiny rephrasing
  Linked files with an absolute path can be opened again (#9129)
  Oberservable Preferences M (CleanupPreferences) (#9126)
  fix broken link
  Fix broken link
  Fix old JabRef linked files containing the file directory as element in the filename (#9046)
  PDFs are not stored next to .bib file if file directory is configured (#9113)
  Remove double stateManager.activeDatabaseProperty() (#9127)
  Don't show the info button when the authors field content is identical (#9128)
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 4, 2022
* upstream/main: (111 commits)
  Fix link and remove obsolete FAQ
  Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (JabRef#9130)
  Tiny rephrasing
  Linked files with an absolute path can be opened again (JabRef#9129)
  Oberservable Preferences M (CleanupPreferences) (JabRef#9126)
  fix broken link
  Fix broken link
  Fix old JabRef linked files containing the file directory as element in the filename (JabRef#9046)
  PDFs are not stored next to .bib file if file directory is configured (JabRef#9113)
  Remove double stateManager.activeDatabaseProperty() (JabRef#9127)
  Don't show the info button when the authors field content is identical (JabRef#9128)
  "study.yml" is static now (JabRef#9125)
  fix l10n
  Compile fix
  Fix parsing of JabRef v5.7 study.yml files (JabRef#9124)
  Fix integrity check  for tilde accents in author names (JabRef#9097)
  Rework the Define study parameters dialog (JabRef#9123)
  Fix parsing of save actions (JabRef#9122)
  Fix exception that occurs when saving name formatters (JabRef#9121)
  Refine code for BibEntry#replaceDownloadedFile (JabRef#9118)
  ...
@koppor koppor mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cleanup-ops component: preferences dev: code-quality Issues related to code or architecture decisions project: jabcon status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants