Skip to content
This repository was archived by the owner on May 25, 2025. It is now read-only.

Commit 433cb37

Browse files
authored
Merge pull request #131 from JasonEtco/fix-context-types
Improve types for context.issue/pull_request
2 parents 08ffc05 + 6d5ecd0 commit 433cb37

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/context.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -73,41 +73,41 @@ export class Context {
7373
public get issue () {
7474
const payload = this.payload
7575

76-
const data: { [k: string]: any } = {
77-
...this.repo
78-
}
79-
76+
let issue_number: number
8077
if (payload.issue) {
8178
// If it's an issue
82-
data.issue_number = payload.issue.number
79+
issue_number = payload.issue.number
8380
} else if (payload.pull_request) {
8481
// If it's a PR
85-
data.issue_number = payload.pull_request.number
82+
issue_number = payload.pull_request.number
8683
} else if (payload.number) {
8784
// Just sittin' there on the payload
88-
data.issue_number = payload.number
85+
issue_number = payload.number
8986
} else {
9087
throw new Error('tools.context.issue cannot be used with this event, there is no issue or pull_request object.')
9188
}
9289

93-
return data
90+
return {
91+
...this.repo,
92+
issue_number
93+
}
9494
}
9595

9696
public get pullRequest () {
9797
const payload = this.payload
9898

99-
const data: { [k: string]: any } = {
100-
...this.repo
101-
}
102-
99+
let pull_number: number
103100
if (payload.pull_request) {
104101
// If it's a PR, the API expects pull_number
105-
data.pull_number = payload.pull_request.number
102+
pull_number = payload.pull_request.number
106103
} else {
107104
throw new Error('tools.context.pullRequest cannot be used with this event, there is no pull_request object.')
108105
}
109106

110-
return data
107+
return {
108+
...this.repo,
109+
pull_number
110+
}
111111
}
112112

113113
public get repo () {

0 commit comments

Comments
 (0)