This repository was archived by the owner on May 25, 2025. It is now read-only.
Improve types for context.issue/pull_request#131
Merged
Conversation
nevilm-lt
pushed a commit
to nevilm-lt/actions-toolkit
that referenced
this pull request
Apr 22, 2022
Improve types for context.issue/pull_request
himanshiLt
pushed a commit
to himanshiLt/actions-toolkit
that referenced
this pull request
Jun 17, 2022
Improve types for context.issue/pull_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Noticed these types were unhelpful - before, it was returning
{ [key: string]: any }, because of how we defineddata.How?
Now we only conditionally define the
issue_numberorpull_number, and return a more strict object that includescontext.repo, so the typing is more specific.