Enable add custom value when allowCreate is true #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @giuse88, this is good :) |
dcousens
added a commit
that referenced
this pull request
May 27, 2015
Enable add custom value when allowCreate is true
Collaborator
Author
|
@dcousens Thank you for merging it. Yeah, I will update my code to use |
Closed
Owner
|
I've renamed the prop to |
Owner
|
Nevermind, just read the subsequent discussion in #197, reverted my change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR enables the add custom field feature despite the number of the filter options. In addition, it moves the
Add new value?as first option in case the list of possible options is big. It mimics the behaviour of selectize.js.This GIF shows the new behaviour:
