feat: replace loop with map lookup - #1323
Merged
Merged
Conversation
baltzell
changed the title
baltzell
marked this pull request as ready for review
June 18, 2026 22:56
baltzell
marked this pull request as draft
June 18, 2026 23:11
baltzell
marked this pull request as ready for review
June 21, 2026 01:40
baltzell
force-pushed
the
decodering-lookups-4
branch
3 times, most recently
from
June 25, 2026 23:26
a565be7 to
a18e9e9
Compare
baltzell
force-pushed
the
decodering-lookups-4
branch
3 times, most recently
from
July 6, 2026 17:24
cad5e11 to
ae6bc4f
Compare
baltzell
force-pushed
the
decodering-lookups-4
branch
from
July 8, 2026 16:34
44b2622 to
4aacfdb
Compare
raffaelladevita
approved these changes
Jul 9, 2026
c-dilks
pushed a commit
that referenced
this pull request
Jul 23, 2026
…/fadc config (#1358) PR #1323 replaced the per-detector `fitterTables` loop in `DetectorEventDecoder.fitPulses` with a direct table lookup and, in doing so, dropped the `hasEntryByHash(hash)` guard that previously protected the `nsa`/`nsb`/`tet`/`pedestal` reads. Because `IndexedTable.getIntValueByHash` does not null-check its internal map lookup, a decoded ADC hit whose `(crate,slot,channel)` is present in `/daq/tt/<det>` but absent from the corresponding `/daq/fadc/<det>` table now unboxes a null `Integer` and throws `NullPointerException` on every such hit. Restore the guard: skip channels that have no FADC config entry, matching the pre-#1323 (14.1.1) behavior. Reproduced on RG-L run 23061: `/daq/tt/ltcc` maps ADC channel (crate 19, slot 18, chan 150) to LTCC sector 4, but `/daq/fadc/ltcc` has no row for it, so 1999/2000 decoded events threw NPE with 14.1.2. With the guard restored the same 2000 events decode cleanly (0 NPE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and breakout into smaller methods