Allow ops review w/open event

README.md

@@ -33,7 +33,7 @@ docker compose up
 http://localhost:8080/dtm
 ```
 
-**Note**: Login with demo username "tbrown" and password "password".
+**Note**: Login with demo username "jdoe" and password "password".
 
 See: [Docker Compose Strategy](https://gist.github.com/slominskir/a7da801e8259f5974c978f9c3091d52c)
 

container/keycloak/initdb.d/03_customize.sh

@@ -46,4 +46,8 @@ create_user
 KC_ROLE_NAME=${KC_RESOURCE}-user
 assign_role
 KC_ROLE_NAME=testlead
+assign_role
+
+KC_USERNAME=jdoe
+KC_ROLE_NAME=${KC_RESOURCE}-reviewer
 assign_role

src/main/java/org/jlab/dtm/business/session/EventFacade.java

@@ -229,18 +229,8 @@ public void editEvent(BigInteger eventId, Date timeUp, String title, BigInteger
             "An event of type " + event.getEventType().getName() + " is already open");
       }
 
-      // if(event.getTimeUp() != null) { // The event is being re-opened
-      // }
       validateEventTimeUp(event, new Date());
 
-      // Clear reviewed by field of all incidents as not supposed to be able to review incidents in
-      // an open event
-      for (Incident incident : event.getIncidentList()) {
-        if (incident.getReviewedUsername() != null) {
-          incident.setReviewedUsername(null);
-        }
-      }
-
       event.setTimeUp(timeUp);
 
       escalationService.resetEscalation(event);

src/main/java/org/jlab/dtm/business/session/IncidentFacade.java

@@ -190,12 +190,6 @@ private void validateAndPopulateIncident(
       if (!reviewer) {
         throw new UserFriendlyException("You must be a reviewer to set the reviewed by field");
       }
-
-      if (!incident.getEvent().isClosed()) {
-        throw new UserFriendlyException(
-            "You cannot review an incident belonging to an open event (Reviewed By field must be empty)");
-      } // NOTE: if you re-open an event we clear all reviewed by fields of sibling incidents
-      // automatically
     }
 
     if (incident.getExpertAcknowledged() == null) {