gen_amp_V2 vertex centering - #408
Merged
Merged
Conversation
… spread the vertex across the target volume by default (same as other generators
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_gen_amp_V2_centerVertex.log |
mashephe
approved these changes
Aug 4, 2026
mashephe
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making this change to make compliant with standard behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add vertex centering as default for gen_amp_V2, which places all generated events at the center of the target (x,y,z) = (0,0,65) cm. This is the default for most generators, which leaves the simulation of the vertex distribution to hdgeant4. When these events are processed by hdgeant4 it first spreads the event vertices randomly across the target volume by default to get the appropriate distribution along the beamline.
Thanks to @duberii for identifying this issue