Implemented #[skip] for the Add derive#472
Merged
tyranron merged 27 commits intoJelteF:masterfrom Dec 1, 2025
Merged
Conversation
tyranron
requested changes
May 22, 2025
Collaborator
tyranron
left a comment
There was a problem hiding this comment.
@ErmitaVulpe thanks!
However, as all our attributes are namespaced (e.g. #[from(skip)] and etc.), I would like to see this PR to stick with this style and have #[add(skip)] instead of just #[skip].
Also, it would be nice if the util::attr::Skip would be reused for this purpose.
Added `#[<method>(skip)]` for `Add` and `AddAssign` as well as `Mul` and `MulAssign` with `#[mul(forward)]` attribute. Generics assigned to a zero sized field are not required to impl the derived method.
Contributor
Author
|
To do this I needed to get a bit more familiar with the codebase and i noticed that Also I changed the way that trait bounds are added to the generics so that the generics contained in the skipped fields do not require the derived trait to be implemented for them. |
tyranron
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #437
Synopsis
As outlined in #437 it isn't possible to derive
Addfor structs containing zero sized fieldsExample:
Solution
Added a
#[skip]attribute that allows to skip zero sized fields like so:Checklist