add search_v2 url support#75
Closed
czhang-blurb wants to merge 1 commit into
Closed
Conversation
houndci-bot
reviewed
Jan 25, 2021
| class Search < DropboxApi::Endpoints::Rpc | ||
| Method = :post | ||
| Path = "/2/files/search".freeze | ||
| Path = "/2/files/search_v2".freeze |
There was a problem hiding this comment.
Naming/ConstantName: Use SCREAMING_SNAKE_CASE for constants.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Owner
|
I want to support the new search_v2 endpoint but we can't just change the endpoint path, we have to update the params and the format of the expected response. I haven't looked thoroughly, but for example I think pagination won't work well if we merge this PR. |
Owner
|
Done in #77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates URL to point to search_v2 endpoint.