Merged
Conversation
Closed
Owner
Author
|
Most things work fine, the only issue is blocked double chests with silent+any active. Presumably this is because OI opens its own copy of the view inventory, so then the viewer counter gets decremented erroneously on exit? Not sure, need to debug. Single chests, unblocked chests, and shulkers do not suffer this issue. |
Owner
Author
|
Ever have one of those moments where you dig through NMS for like 30 minutes only to realize it was a non-NMS change that wasn't thoroughly tested that messed things up? Me too. Really gotta write some unit tests, dang it. |
Looks like this method was added in 1.19, but I didn't notice because there weren't any related issues and the actual referenced internal code was unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per usual, I am pushing the work out now rather than make technically-savvy early adopters wait until I have time to test. Builds are available in the "dist" artifact of successful Actions runs.