Skip to content

Add service LaunchAgent management#92

Merged
JoeyTeng merged 5 commits into
masterfrom
codex/c6-service-install-manage
May 19, 2026
Merged

Add service LaunchAgent management#92
JoeyTeng merged 5 commits into
masterfrom
codex/c6-service-install-manage

Conversation

@JoeyTeng
Copy link
Copy Markdown
Owner

Note

This PR is purely generated by LLM: OpenAI Codex (GPT-5.5 (reasoning xhigh, summaries auto)).

Summary

  • Add cbth service install, cbth service uninstall, and cbth service status.
  • Manage macOS login autostart through a user LaunchAgent that starts cbth --home <path> service run.
  • Keep Linux user systemd as a documented future shape and avoid Webex/plugin release-manager internals.

Validation

  • cargo fmt --check
  • cargo test --lib service::tests -- --test-threads=1
  • cargo test --test cli_help -- --test-threads=1
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo test --locked
  • uv run /Users/hoteng/.codex/skills/project-journal/scripts/project_journal.py validate --repo .
  • commit hook repeated cargo fmt --all, cargo clippy --locked --all-targets -- -D warnings, and cargo test --locked

Review

  • Local pre-commit helper-backed codex-review live-snapshot review completed with no blocking findings.
  • PR readiness follow-up will run online @codex review / codex/review-gate, offline frozen-diff review, CI, and PR comment cleanup before merge.

Add cbth service install, uninstall, and status for macOS LaunchAgent autostart. Generate a LaunchAgent that runs cbth service run with the selected home, report launchctl state, and keep Linux user systemd as future documented shape.

Co-authored-by: Codex (model=GPT-5) <codex@openai.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

codex/review-gate state

  • head: db928f3aee69d897ee0d8f80c3f2b02a8a8c8799
  • marker: none
  • updated: 2026-05-19T21:41:03.231Z

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Update the C6 project journal with the created pull request URL.

Co-authored-by: Codex (model=GPT-5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 042aef661c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/service.rs
Re-enable the macOS LaunchAgent label during service install so a previously disabled login item can be restored before bootstrap. Also render LaunchAgent log paths as absolute paths to match the generated service run home.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Treat launchctl missing-domain output like a not-loaded service so status and uninstall still work in headless macOS sessions without an active gui launchd domain.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Ensure cbth service status reports changed=false even when the generated LaunchAgent plist would differ from disk state, and cover the reporting behavior with a focused unit test.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@JoeyTeng JoeyTeng merged commit bcc0d38 into master May 19, 2026
6 of 7 checks passed
@JoeyTeng JoeyTeng deleted the codex/c6-service-install-manage branch May 19, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant