Skip to content

Add plugin release manager primitives#93

Merged
JoeyTeng merged 4 commits into
masterfrom
codex/c7-plugin-release-manager
May 19, 2026
Merged

Add plugin release manager primitives#93
JoeyTeng merged 4 commits into
masterfrom
codex/c7-plugin-release-manager

Conversation

@JoeyTeng
Copy link
Copy Markdown
Owner

Note

This PR is purely generated by LLM: OpenAI Codex (GPT-5.5 (reasoning xhigh, summaries auto)).

Summary

  • Add C7 plugin lifecycle RPC contract types and method/capability constants.
  • Add service-owned plugin release manager primitives for shadow prepare, pre-active health, quiesce, drain, optional handoff, promote, shutdown, and rollback.
  • Add a dedicated lifecycle control client that is instance-bound, timeout-bounded, and not allowed to reuse the plugin runtime socket.
  • Update C7 design and project journal docs with landing state and W5/W6 dependencies.

Validation

  • cargo fmt --check
  • git diff --check
  • uv run --no-project /Users/hoteng/.codex/skills/project-journal/scripts/project_journal.py validate --repo /private/tmp/cbth-c7-plugin-release-manager
  • cargo test --target-dir /private/tmp/cbth-c7-plugin-release-manager/target --lib -- --test-threads=1
  • cargo clippy --target-dir /private/tmp/cbth-c7-plugin-release-manager/target --locked --all-targets -- -D warnings
  • pre-commit hook: cargo fmt --all, cargo clippy --locked --all-targets -- -D warnings, cargo test --locked

Review Evidence

  • Offline helper-backed Codex review: /private/tmp/cbth-c7-plugin-release-manager/.codex-tmp/isolated-review-sjum1plu, status passed, no actionable findings.
  • Earlier helper findings around lifecycle socket routing, timeout restoration, rollback unquiesce, ambiguous quiesce, identity binding, and shadow cleanup were fixed before this PR was opened.

Add lifecycle RPC contract types, dedicated lifecycle control client plumbing, conservative shadow upgrade orchestration, rollback coverage, and C7 landing docs.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5.5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

codex/review-gate state

  • head: 129aec91a2b2d922e2aafec308d941da91f016e1
  • marker: none
  • updated: 2026-05-19T22:01:08.175Z

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Link the C7 project journal entry to the opened PR.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5.5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

Add the pre-active delivery commit gate to the lifecycle health-check payload so plugin implementations can enforce the full shadow-instance fence.

Co-authored-by: Codex (tool=Codex CLI; model=GPT-5) <codex@openai.com>
@github-actions
Copy link
Copy Markdown

@codex review

Note

This workflow is requesting a Codex generative AI review.
Codex may post AI-generated comments or reviews on this pull request.
Review and verify AI-generated output before relying on it for security, correctness, or merge decisions.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@JoeyTeng JoeyTeng merged commit d58400f into master May 19, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant