Skip to content

fallback for custom deserializers and serializers#174

Merged
Neos3452 merged 19 commits intoJohnWeisz:masterfrom
amoscatelli:master
Mar 7, 2021
Merged

fallback for custom deserializers and serializers#174
Neos3452 merged 19 commits intoJohnWeisz:masterfrom
amoscatelli:master

Conversation

@amoscatelli
Copy link
Copy Markdown
Contributor

No description provided.

@amoscatelli
Copy link
Copy Markdown
Contributor Author

#172

@amoscatelli
Copy link
Copy Markdown
Contributor Author

@Neos3452 it was harder than I imagined
Anyway I did exactly what you asked

I hope you'll merge the pull request soon

Thank you

Copy link
Copy Markdown
Collaborator

@Neos3452 Neos3452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I think this will be very valuable addition to the library. I just left a couple technical comments, the only major thing is to keep the custom serialisation callbacks compatible with the existing version. One more thing, do you think you could add a short note about this feature to the readme in the "serializer and deserializer" section? That would really make this shine.

When you make the adjustments, I will release a rc version so you can already use it in your project.

Comment thread src/metadata.ts Outdated
Comment thread src/metadata.ts Outdated
Comment thread src/metadata.ts Outdated
Comment thread src/metadata.ts Outdated
Comment thread src/metadata.ts Outdated
Comment thread src/parser.ts Outdated
Comment thread src/parser.ts Outdated
Comment thread spec/custom-serializer.spec.ts Outdated
Comment thread spec/lazy-types/custom-deserializer.spec.ts
Comment thread spec/lazy-types/custom-serializer.spec.ts Outdated
@amoscatelli amoscatelli requested a review from Neos3452 March 7, 2021 11:33
@amoscatelli
Copy link
Copy Markdown
Contributor Author

@Neos3452 I made the change you requested. Also I provided a short description for fallback functionality and an example.

Hoping to get the RC soon.

Thank you.

@Neos3452 Neos3452 merged commit b9faf17 into JohnWeisz:master Mar 7, 2021
@Neos3452
Copy link
Copy Markdown
Collaborator

Neos3452 commented Mar 7, 2021

Great work! Thanks a lot for this. You can try your changes with version 1.8.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants