Merged
Conversation
Caused by singleline table just hitting column width initially with no spaces between braces
We did not look at the RHS precedence level when determining to hang an expression. This led to assymetric formatting, which doesn't look as nice. This also led to an unstable formatting issue in #261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261 (OP) - caused by a singleline table just hitting the column width, with initially no spaces between braces. We did not correctly calculate the column width in this case.
Fixes #257 - for the top-level binop expression, we did not take into account whether we hung the RHS of the expression and its precedence level. This led to an asymmetric formatting, which did not look as nice. This was also presented as a comment in #261 leading to unstable formatting.