Skip to content

Fix unstable formatting around comments in type declarations #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnnyMorganz merged 10 commits into from
Apr 8, 2022
Merged

Fix unstable formatting around comments in type declarations #435

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9c826e0
Add test case
JohnnyMorganz Apr 2, 2022
5241b35
Hang at equals token if comment between token and definition
JohnnyMorganz Apr 2, 2022
18068b0
Improve formatting of GenericDeclarations when comments present
JohnnyMorganz Apr 2, 2022
60e98a3
Make leading multiline comments in generics also force expansion
JohnnyMorganz Apr 2, 2022
0e5a3dc
Handle comments between type name, generics and equals token
JohnnyMorganz Apr 2, 2022
c0880b7
Update changelog
JohnnyMorganz Apr 2, 2022
61d8543
Accept test cases
JohnnyMorganz Apr 2, 2022
8486ee4
Accept changed snapshot - I'm not too sure on this one...
JohnnyMorganz Apr 2, 2022
3023b35
Feature gates
JohnnyMorganz Apr 2, 2022
e996c06
Merge branch 'master' of https://github.com/JohnnyMorganz/StyLua into…
JohnnyMorganz Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changelog
  • Loading branch information
@JohnnyMorganz
JohnnyMorganz committed Apr 2, 2022
commit c0880b7f32c7a3511067a92b8c546e752eafa66d
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed leading trivia on semicolon lost when semicolon is removed ([#431](https://github.com/JohnnyMorganz/StyLua/issues/431))
- Fixed shape calculation of the RHS of a binary expression not correctly reset when hanging, causing it to expand unnecessarily ([#432](https://github.com/JohnnyMorganz/StyLua/issues/432))
- Fixed unstable formatting around comments within type declarations ([#397](https://github.com/JohnnyMorganz/StyLua/issues/397), [#430](https://github.com/JohnnyMorganz/StyLua/issues/430))

## [0.13.0] - 2022-03-31
### Added
Expand Down