Inline first call in chain depending on heuristics#476
Merged
JohnnyMorganz merged 2 commits intohang-chained-static-funcsfrom Jun 27, 2022
Merged
Inline first call in chain depending on heuristics#476JohnnyMorganz merged 2 commits intohang-chained-static-funcsfrom
JohnnyMorganz merged 2 commits intohang-chained-static-funcsfrom
Conversation
Contributor
Repo Comparison TestNo diff produced |
Owner
Author
|
In conversation - this diff is not necessary and shouldn't reformat: local function interpolateVariables(title: string, template: Template, index: number): string
return Array.reduce(
Array.reduce(Object.keys(template), getMatchingKeyPaths(title), {}), -- aka flatMap
replaceKeyPathWithValue(template),
title
):gsub(
"%$#", -- ROBLOX deviation: escaped string
tostring(index),
1
)
end
|
Contributor
Repo Comparison TestNo diff produced |
JohnnyMorganz
added a commit
that referenced
this pull request
Jul 5, 2022
* Hang static chained function calls * Inline first call in chain depending on heuristics (#476) * Inline first chain call using heuristics * Keep chain inlined if the first call is inlined and there is only 2 indexes * Expand call chain if inlined version goes over width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heuristics are same as prettier:
AND inlining doesn't go over width