Fix aarch64 target#529
Merged
JohnnyMorganz merged 3 commits intoJohnnyMorganz:masterfrom Aug 8, 2022
mvllow:patch-1
Merged
Conversation
According to rust-lang/rust#73908 this should be supported. Closes #528
JohnnyMorganz
approved these changes
Aug 8, 2022
Owner
JohnnyMorganz
left a comment
JohnnyMorganz
left a comment
There was a problem hiding this comment.
Do you mind adding a quick sentence under "Fixed" in the CHANGELOG?
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 14 14
Lines 5390 5390
=======================================
Hits 5264 5264
Misses 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Added to the unreleased section as I assume this will require a version bump but happy to change if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to rust-lang/rust#73908 this should be supported. Not sure of an easy way to test the workflow but let me know if there's anything else that's needed :)
Closes #528