Corr extinction#3
Open
robinlombaert wants to merge 10 commits into
Open
Conversation
…odule with image module in sed.builder.py.
Updated the installation instruction to include temporarily moving the io folder elsewhere to avoid conflicts between this module and the Python standard io module.
Changed the repository location to the robinlombaert account, as this version contains the most recent updates.
Changed installation instructions in terms of when to do what.
- Added a new extinction law for interstellar reddening, which is a combination of Chiar and Tielens 2006 and Fitzpatrick 2004. - Updated some comments in the code to reflect the correct functionality Bugs: - get_law did not convert to the requested wavelength unit when not asking for photbands. Fixed. - When importing image in the sed builder, sometimes the installed package is actually called Image instead. In that case, the code now imports Image as image
Added some trouble shooting with f2py.
…s 2006 for galactic center and local ism. Removing the import of the scipy.optimize anneal module which has been removed as of scipy version 0.16.0. The call to the scipy_anneal module was commented out. A warning that the module didn't work anymore was already being printed.
… passbands is done with the correct curve type in the Chiar and Tielens 2006 case. Had to add **kwargs to the function calls of the different extinction models, and their respective get_law calls.
JorisDeRidder
pushed a commit
that referenced
this pull request
Dec 11, 2017
Bring up to date with the version from the IT-training (+ a few additional fixes since then)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new extinction model and fixed some documentation and small bugs in the sed module.
Also implemented a proper, robust fix for the python distribution-dependent import error of the Image module. It now tries to import image, and if that fails it imports Image instead. Works for both cases.
Also updated the readme file with updated installation instructions, including a temporary fix for the io module issue.
This pull request includes my previous pull request (which I've removed).