Skip to content

API Controller Implementation for student self enrolment#4

Merged
JosephKS10 merged 1 commit into
feature/student_self_enrolmentfrom
feature/student_self_enrolment_api
Sep 20, 2025
Merged

API Controller Implementation for student self enrolment#4
JosephKS10 merged 1 commit into
feature/student_self_enrolmentfrom
feature/student_self_enrolment_api

Conversation

@JosephKS10
Copy link
Copy Markdown
Owner

Description

Implement API endpoints to support tutorial self-enrolment configuration and student enrolment functionality.

  • Update TaskDefinitionsApi
  • Create Student Tutorial Enrolment API
  • Mount New API

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Automated Testing

rails test test/api/student_tutorial_enrolment_api_test.rb


Screenshot 2025-09-18 at 7 38 56 PM

rails test test/models/task_definition_self_enrolment_test.rb


Screenshot 2025-09-18 at 7 40 09 PM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes

If you have any questions, please contact @macite or @jakerenzella.

Copy link
Copy Markdown

@nouri-devv nouri-devv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JosephKS10, this looks really well and the tests all passed. Really good work and happy to approve this.

Copy link
Copy Markdown

@gauravmyana2002 gauravmyana2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JosephKS10

The API is well structured and easy to follow, with clear separation of concerns between authentication, authorization, and enrolment logic. The flow for creating or updating enrolments is straightforward and handles capacity and validation checks neatly. Test coverage is strong, covering the main scenarios and giving confidence in the behavior. The responses are also clear and provide the right details back to the client, which makes the integration side simple. Overall, the changes fit in cleanly with the existing codebase and add the new functionality in a consistent way.

Copy link
Copy Markdown

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JosephKS10

Solid work on this. After pulling your changes into my dev environment, I was able to confirm the endpoint’s functionality. It passed the Rails tests, and I further stress-tested it using the SSRF bash script from DoubtFire Astro. I can confirm the endpoint’s response time is consistent with the others and its functionality is correctly implemented.

@JosephKS10 JosephKS10 merged commit 0a35d47 into feature/student_self_enrolment Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants