API Controller Implementation for student self enrolment#4
Conversation
nouri-devv
left a comment
There was a problem hiding this comment.
Hi @JosephKS10, this looks really well and the tests all passed. Really good work and happy to approve this.
gauravmyana2002
left a comment
There was a problem hiding this comment.
Hey @JosephKS10
The API is well structured and easy to follow, with clear separation of concerns between authentication, authorization, and enrolment logic. The flow for creating or updating enrolments is straightforward and handles capacity and validation checks neatly. Test coverage is strong, covering the main scenarios and giving confidence in the behavior. The responses are also clear and provide the right details back to the client, which makes the integration side simple. Overall, the changes fit in cleanly with the existing codebase and add the new functionality in a consistent way.
ibi420
left a comment
There was a problem hiding this comment.
Hey @JosephKS10
Solid work on this. After pulling your changes into my dev environment, I was able to confirm the endpoint’s functionality. It passed the Rails tests, and I further stress-tested it using the SSRF bash script from DoubtFire Astro. I can confirm the endpoint’s response time is consistent with the others and its functionality is correctly implemented.
Description
Implement API endpoints to support tutorial self-enrolment configuration and student enrolment functionality.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
rails test test/api/student_tutorial_enrolment_api_test.rbrails test test/models/task_definition_self_enrolment_test.rbChecklist:
If you have any questions, please contact @macite or @jakerenzella.