Discord API by samuelthomas2774 · Pull Request #191 · JsSucks/BetterDiscordApp

samuelthomas2774 · 2018-04-14T20:44:49Z

Additional changes not related to the Discord API:

Wrap Discord's preload script instead of enabling Node integration
Add multi option radio settings
Add getting all components used to render a single element to Reflection
Add the ability to pass a filter to ReactComponents to select the correct component from Reflection
Add data attributes to the user profile modal
Patch the user profile modal component instead of waiting for it to be opened
Add data attributes to the user popout
Patch all components at once instead of waiting for the previous component to be found and patched
Make some Vue components available to plugins
Move Filters to common and and it to the plugin API
Add ReactHelpers to the plugin API
Add DOM, DOMObserver and VueInjector to the plugin API
Add a function to wrap a Vue component in a React component
Add getting known modules as properties of WebpackModules
Use top and left to position tooltips and popovers
Use Date instead of Moment.js in Logger
Show proxies instead of the target in logs
Allow patching arrays
Get class names from WebpackModules
Add highlight.js to WebpackModules
Rename HTMLUtils to SimpleMarkdown
Use Node.js v8 for Travis CI builds
Use ES6 imports/exports
Fix favourite emotes array being undefined when loading settings
Fix colour picker/dropdrop options being hidden when in a drawer
Fix EventsWrapper not unsubscribing to events
Fix badges not being rendered when jumping to a message
Fix settings panel not displaying on Linux
Fix for webpack 4

… of their type

So comparisons like `DiscordApi.currentUser === DiscordApi.currentUser` can be true

…build

zerebos · 2018-04-14T21:02:57Z

Aside from the snake_case being there (especially since it's being intermixed with camelCase), I would approve this. It's pretty close to the restructure I had planned for the next version of the API anyways and takes quite a few things to add off my list.

…ction before opening it

zerebos

Overall I think this restructure is nice, as it gives more explicit types to objects. There were a couple errors, and some naming convention issues that should be addressed however.

zerebos · 2018-04-25T18:42:35Z

+    async ensurePrivateChannel() {
+        if (DiscordApi.currentUser === this)
+            throw new Error('Cannot create a direct message channel to the current user.');
+        return Channel.from(await Modules.PrivateChannelActions.ensurePrivateChannel(DiscordApi.currentUser.id, this.id));


This should use Channel.fromId since ensurePrivateChannel returns the ID of the channel

zerebos · 2018-04-25T18:48:50Z

+    /**
+     * Whether this channel is the guild's default channel.
+     */
+    get default_channel() {


boolean return should have affirmative or "is" prefix. default_channel should be isDefaultChannel

zerebos · 2018-04-25T18:58:37Z

+        let response = {};
+        if (parse) response = await Modules.MessageActions._sendMessage(this.id, Modules.MessageParser.parse(this.discordObject, content));
+        else response = await Modules.MessageActions._sendMessage(this.id, {content});
+        return Message.from(Modules.MessageStore.getMessage(this.id, response.body.id));


Looks like it returns Message but you have it labelled as returning Promise

This is an async function so the actual return value is a promise. I'll add that it resolves to a message.

Fair point, actual return is the Promise, but I think it's best we say what it resolves to especially since it should always resolve to Message type

zerebos · 2018-04-25T19:03:16Z

+    static get GroupChannel() { return GroupChannel }
+
+    get id() { return this.discordObject.id }
+    get application_id() { return this.discordObject.application_id }


I'll make this comment once, but it applies throughout all these changes. You have a mix of snake_case and camelCase here and the codebase we have already has been going with camelCase although of course we have consistencies in the codebase itself but I think it's better to make sure we consistently use camelCase. For reference look at the similar structs done here: https://github.com/JsSucks/BetterDiscordApp/tree/master/client/src/structs/socketstructs

I can tell you were trying to use snake_case for attributes but it wasn't done consistently and it feels weird to have two quite different naming schemes happening at the same time.

I forgot about the socket structs. I tried to normalise attribute names to snake case as Discord was using them inconsistently. I'll change these to camel case then.

zerebos · 2018-04-25T19:14:20Z

+    /**
+     * Whether this channel is currently selected.
+     */
+    get selected() {


We should probably change this to isSelected

zerebos · 2018-04-25T19:59:41Z

+    /**
+     * Whether this channel is currently selected.
+     */
+    get selected() {


Like the other one we should probably rename to isSelected

zerebos · 2018-04-25T20:07:26Z

+
+    /**
+     * Deletes the message.
+     * TODO: how do we know if the message was deleted successfully?


We can do a temporary subscribe to the message delete event

That would tell us if the message was deleted successfully, but won't help if it isn't. We would only be able to tell if it failed if a timeout passes and we wouldn't be able to tell if an error had been returned.

Internally it does attempt to retry for awhile if there are errors and then fire the event when it completes. Otherwise we could copy the internals of the deleteMessage function but add in passing the error callback to the delete() request

zerebos · 2018-04-25T20:14:00Z

+     * Deletes the message.
+     * TODO: how do we know if the message was deleted successfully?
+     */
+    delete() {


We should probably add a permission check similar to edit message here

zerebos · 2018-04-25T20:20:57Z

+        return Modules.UserStatusStore.getActivity(this.id);
+    }
+
+    get direct_messages() {


name here is unclear, makes it seem like it would return a list of all the DMs

I've renamed this to privateChannel.

zerebos · 2018-04-25T20:24:24Z

-        Modules.MessageActions.startEditMessage(this.channel_id, this.id, this.content);
-    }
+    static get modules() { return Modules }
+    static get User() { return User }


Just curious, is the point of having all the types as static members a way for plugins to check types of objects?

I originally added it so you could use static functions like Channel.fromId where you had a channel's ID instead of getting all channels. I didn't actually think about that.

Ah alright, that works as well, I didn't think about it that way either. Personally I have been doing api.channels.find(c => c.id == "XXXXXXXXXX") 😀

…icates when multiple modals are opened at the same time

# Conflicts: # client/src/modules/pluginapi.js # client/src/ui/bdui.js # client/src/ui/dom.js # client/src/ui/ui.js # package-lock.json # package.json

…dMember classes

…ng them

…ossible

samuelthomas2774 · 2018-08-01T22:10:34Z

Add toasts (JsSucks/toasts)
- Added an option to add additional classes to the toast element
Add class normaliser
- Classes like guildsWrapper-5TJh6A are normalised to da-guilds-wrapper
Add support for (transpiled) ES6 modules as a plugin's main file
Emit events when loading (Discord) modules
- module-loading with the module object before the module is evaluated
- module-loaded with the module object after the module is evaluated
- modules-loaded with an array of module objects after they've loaded
Add functions to wait for modules to be loaded
Add getting all stateNodes to Reflection
Add a function to force update all instances of a component
Delete old logs on startup
Add custom window preferences
Add settings section to edit window preferences
Add settings proxy
- Values can be retrieved from sets/categories as normal properties: set.proxy.category.setting
Use request to check for updates
Disable loading of emotes when emotes are disabled
Use an observer to detect new React components instead of a timer
Fix escape key closing all modals
Fix keybind settings not activated when in a text input
Fix components not being selected properly due to Discord updates
Fix leaks in keybind settings
- Plugins must unbind the keybind-activated event from all keybind settings they bind to when stopping or when removing the last reference to them
Add development webpack plugins

zerebos · 2018-08-05T19:07:55Z

Re: The weakmaps/sets it goes against the point of them because the references are supposed to be weak and allow garbage collection, what you were doing introduces non-determinism.

samuelthomas2774 added 20 commits April 13, 2018 19:50

Add shortcut to plugin/theme/extmodule manager content

d5f486d

Move data types to separate files and further separate channels based…

f1e0350

… of their type

Store objects in a WeakMap

33c0732

So comparisons like `DiscordApi.currentUser === DiscordApi.currentUser` can be true

Add roles

e061d95

Add channel permission overwrites

68e42b8

Check if the member exists before creating a GuildMember

a7b300d

Add user status/activity

1b75753

Allow after patches to change the return value

9dc424c

Add user settings

4d5a403

Add opening channel/guild settings window

ac22b14

More modals

8b320d2

Wrap User instead of extending it

48f4837

Add guild emojis

4837a01

Add file headers

146e108

Fix development CSS editor build being copied instead of the release …

bcb8881

…build

Add reactions

695d088

Add embeds

6d64d17

Separate messages into their types

a1c6f5d

Some comments

21ff9d2

Fixes and add file header to list

ad710de

samuelthomas2774 added 4 commits April 15, 2018 00:54

Fix guild.owner

96952c3

Add opening the user’s profile modal

e524c50

Fix guild member methods and set the guild/channel settings window se…

32452d9

…ction before opening it

Merge branch 'master' into discord-api

525fd31

Jiiks requested a review from zerebos April 21, 2018 17:38

samuelthomas2774 added 3 commits April 25, 2018 13:21

Add multi option radios

c3e4563

Fix nickname checks and add changing nicknames programmatically

c294df6

Add sending local bot messages

5a6fb99

zerebos requested changes Apr 25, 2018

View reviewed changes

samuelthomas2774 added 22 commits July 18, 2018 21:53

Add all Map and Set methods to IterableWeakMap and IterableWeakSet

821f464

Use a counter instead of the current time for modal IDs to avoid dupl…

27f1eec

…icates when multiple modals are opened at the same time

Prevent modals from being added to the stack more than once

6ded1c6

Merge remote-tracking branch 'upstream/toasts' into toasts

007637a

# Conflicts: # client/src/modules/pluginapi.js # client/src/ui/bdui.js # client/src/ui/dom.js # client/src/ui/ui.js # package-lock.json # package.json

Requested changes from JsSucks#194

a95b97b

Add an option to add additional classes to toasts

1d88796

Merge branch 'toasts' into discord-api

5301498

Fix syntax error at %

19bbd42

Fix error with process.binding

71c2d3a

Fix request module not found

81e392c

Fix MessageGroup component selection

7a416c0

Add getting all state nodes to Reflection

1a12430

Add a function to force update all instances of a component

a20473d

Fix emotes

331b2b3

Fix Message component selection and add bd-isGuildOwner and bd-isGuil…

0c82793

…dMember classes

Fix errors when rendering system messages

3a7ac06

Fix Guild component selection

db21f4e

Use ReactComponent.forceUpdateAll to rerender components after patchi…

5b419cb

…ng them

Use an observer to detect new React components

8826a7b

Remove IterableWeakCollections and deactivate keybind settings when p…

16bb32b

…ossible

Fix removing keybind-activated listeners

a5ff8bb

Update dependencies

33488d7

samuelthomas2774 added 3 commits August 2, 2018 20:24

Add using a file as a plugin/theme’s icon

9af8a71

Fix keybind settings not activating

6ea8534

Fix unread mentions indicator position

342b4cd

zerebos merged commit 520366c into JsSucks:master Aug 5, 2018

snyk-bot mentioned this pull request Mar 12, 2020

[Snyk] Security upgrade asar from 1.0.0 to 3.0.0 #372

Open

Jiiks mentioned this pull request Feb 2, 2024

[Snyk] Security upgrade asar from 1.0.0 to 3.2.0 #411

Open

Conversation

samuelthomas2774 commented Apr 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zerebos commented Apr 14, 2018

Uh oh!

zerebos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samuelthomas2774 Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samuelthomas2774 commented Aug 1, 2018

Uh oh!

zerebos commented Aug 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

samuelthomas2774 commented Apr 14, 2018 •

edited

Loading

samuelthomas2774 Apr 25, 2018 •

edited

Loading