Plugin permissions#239
Open
Maks-s wants to merge 7 commits into
Open
Conversation
Member
|
oh not nearly as thorough as I thought it would be, also having |
Author
|
What should be added for it to be thorough ? |
Member
|
Lots of additional permissions for plugins access to things like parts of DiscordApi. |
Author
|
Hmm, this PR is meant to only add a system for permissions, not actually add the permissions. getPlugin / getTheme / getModule are more of a PoC EDIT: Also changed functions name to
|
samuelthomas2774
suggested changes
Aug 23, 2018
| Logger.warn(this.moduleName, [`Failed reading config for ${this.contentType} ${readConfig.info.name} in ${dirName}`, err]); | ||
| } | ||
|
|
||
| if (this.contentType === 'plugin') { |
There was a problem hiding this comment.
Everything here should be in the plugin manager.
| }, | ||
| GET_INSTALLED_COMPONENT: { | ||
| HEADER: 'Use installed components', | ||
| BODY: 'Allows :NAME: to interact with other plugins / themes / modules' |
There was a problem hiding this comment.
Plugins can already interact with other plugins, so maybe control instead of interact with?
| * @param {String} permission Permission to add | ||
| * @return {Promise} | ||
| */ | ||
| static async add(id, permission) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin permissions system
Add the following functions to Permissions Manager :
+ add permission check for getPlugin / getTheme / getModule with GET_INSTALLED_COMPONENT