Skip to content

Remove @with, add @attach#367

Closed
pdeffebach wants to merge 13 commits intomasterfrom
with_to_attach
Closed

Remove @with, add @attach#367
pdeffebach wants to merge 13 commits intomasterfrom
with_to_attach

Conversation

@pdeffebach
Copy link
Copy Markdown
Collaborator

fixes #364

@bkamins
Copy link
Copy Markdown
Member

bkamins commented Nov 1, 2023

CI errors

I do not see where you deprecate @with (I think we should keep it at least for a while). @nalimilan - what do you think?

pdeffebach and others added 5 commits November 1, 2023 11:06
Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>
Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>
@pdeffebach
Copy link
Copy Markdown
Collaborator Author

Tests pass

@bkamins
Copy link
Copy Markdown
Member

bkamins commented Nov 2, 2023

There are some doctest failures

@pdeffebach
Copy link
Copy Markdown
Collaborator Author

This can be a small version bump, right? Since it just deprecates, we don't need to make a 0.15.0 version.

@bkamins
Copy link
Copy Markdown
Member

bkamins commented Nov 7, 2023

we add new @attach. In the past, we would e.g. in DataFrames.jl make 0.15 release. But recently people were saying that such minor changes are OK to be made in 0.14.2.

@pdeffebach
Copy link
Copy Markdown
Collaborator Author

Okay I'm just going to merge this with a minor version bump. I don't want to release too many breaking changes and I want people to see the deprecation.

I will also announce on discourse soon.

@bkamins
Copy link
Copy Markdown
Member

bkamins commented Dec 14, 2023

OK

@nalimilan
Copy link
Copy Markdown
Member

Sorry, for some reason I missed this. It's really unfortunate that Julia exports this general name now. Have you considered calling it @within instead of @attach (which indeed has a bad reputation in R as it attaches copies of columns to the global environment)?

@pdeffebach
Copy link
Copy Markdown
Collaborator Author

@within is a good name. I guess I still prefer @attach since

  1. It's a verb, kind of like @select, @transform etc.
  2. I like the idea of us re-doing an R feature, but "correctly", without the scoping and performance drawbacks of attach.

@pdeffebach
Copy link
Copy Markdown
Collaborator Author

Closing this due to JuliaLang/julia#53004 (comment) being merged

@pdeffebach pdeffebach closed this Mar 28, 2024
@pdeffebach pdeffebach deleted the with_to_attach branch November 1, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@with macro clashes with Base.@with in Julia 1.11+

3 participants