Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 9
Lines 1556 1628 +72
======================================
- Misses 1556 1628 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ah, well, it will actually require #619 first. |
serenity4
commented
Mar 7, 2025
Comment on lines
+4
to
+8
| using Core.Compiler: widenconst | ||
|
|
||
| has_name_typ(node, name::Symbol, @nospecialize(Ts::Tuple)) = kind(node) == K"Identifier" && node.val === name && node.typ in Ts | ||
| has_name_typ(node, name::Symbol, @nospecialize(T)) = kind(node) == K"Identifier" && node.val === name && node.typ === T | ||
| has_typ(node, @nospecialize(Ts::Tuple)) = any(has_typ(node, T) for T in Ts) | ||
| has_typ(node, @nospecialize(T)) = node.typ === T || !isnothing(node.typ) && widenconst(node.typ) === T | ||
| has_name_typ(node, name::Symbol, @nospecialize(T)) = kind(node) == K"Identifier" && node.val === name && has_typ(node, T) |
Collaborator
Author
There was a problem hiding this comment.
Not 100% sure about these changes. Essentially, what I have been assuming is that it doesn't matter whether the node type is a Const or not, so long as the type of the value is correct, if we test it against a non-Const type.
Member
There was a problem hiding this comment.
Yeah, this change looks reasonable.
aviatesk
approved these changes
Mar 18, 2025
Comment on lines
+4
to
+8
| using Core.Compiler: widenconst | ||
|
|
||
| has_name_typ(node, name::Symbol, @nospecialize(Ts::Tuple)) = kind(node) == K"Identifier" && node.val === name && node.typ in Ts | ||
| has_name_typ(node, name::Symbol, @nospecialize(T)) = kind(node) == K"Identifier" && node.val === name && node.typ === T | ||
| has_typ(node, @nospecialize(Ts::Tuple)) = any(has_typ(node, T) for T in Ts) | ||
| has_typ(node, @nospecialize(T)) = node.typ === T || !isnothing(node.typ) && widenconst(node.typ) === T | ||
| has_name_typ(node, name::Symbol, @nospecialize(T)) = kind(node) == K"Identifier" && node.val === name && has_typ(node, T) |
Member
There was a problem hiding this comment.
Yeah, this change looks reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix test failures for nightly, so it is easier to test & approve changes for PRs.