stop redefining rules for redirect_stdio on 1.6#358
Merged
simeonschaub merged 2 commits intomasterfrom Feb 13, 2021
Merged
Conversation
github-actions
bot
added
the
needs version bump
simeonschaub
added
blocked
oxinabox
approved these changes
Feb 10, 2021
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
LGTM once CI passes.
Don't forget to bump version before merging
simeonschaub
force-pushed
the
sds/fix_redef
branch
from
32917e5 to
0fa291b
Compare
github-actions
bot
removed
the
needs version bump
simeonschaub
removed
the
blocked
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 19 19
Lines 1487 1487
=======================================
Hits 1454 1454
Misses 33 33 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref JuliaLang/julia#39132. I have also widened the signature here, since those correspond to the ones in Base. Not sure how to test this, I don't think there's a nice way to test the absence of method redefinition warnings when loading a module. Still requires JuliaDiff/ChainRulesCore.jl#298.