Merged
Conversation
Member
|
Thanks |
Member
Author
|
I'm not 100% sure how necessary this is, but probably better to be on the safe side. |
Wrap objects in a Ref to avoid immutable relocation problems.
simonbyrne
force-pushed
the
sb/callback-ref
branch
from
1921b24 to
7b0ec84
Compare
Member
Author
|
@yuyichao Is this handling of function callbacks correct? Or is there a better way we should be doing this? |
|
Looks correct. A better way, if the performance of the callback is important, would be to do sth similar to JuliaMath/Cubature.jl#23 to allow specialization of the callback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap immutable objects in a Ref to avoid the jl_value_ptr problems