Skip to content

Zeros #19635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViralBShah merged 9 commits into from
Dec 22, 2016
Merged

Zeros #19635

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39a3bde
Add methods to zeros, ones.
jw3126 Nov 10, 2016
b3a93f2
news
jw3126 Dec 21, 2016
38d34e7
fix
jw3126 Dec 21, 2016
8f824a2
fix
jw3126 Dec 21, 2016
259668b
fix
jw3126 Dec 21, 2016
757e7ac
fix
jw3126 Dec 21, 2016
b71e9e0
fix
jw3126 Dec 21, 2016
e80a695
fix
jw3126 Dec 21, 2016
85c3f0a
fix
jw3126 Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions base/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,15 @@ fill(v, dims::Integer...) = fill!(Array{typeof(v)}(dims...), v)

for (fname, felt) in ((:zeros,:zero), (:ones,:one))
@eval begin
function ($fname)(a::AbstractArray, T::Type=eltype(a), dims::Tuple=size(a))
fill!(similar(a,T,dims), $felt(T))
end
($fname)(T::Type, dims::Tuple) = fill!(Array{T}(dims...), $felt(T))
($fname)(dims::Tuple) = ($fname)(Float64, dims)

($fname)(a::AbstractArray,T::Type,dims::DimOrInd...) = ($fname)(a,T,dims)
($fname)(T::Type,dims::DimOrInd...) = ($fname)(T,dims)
($fname)(dims::DimOrInd...) = ($fname)(dims)
# allow signature of similar
$fname(a::AbstractArray, T::Type, dims::Tuple) = fill!(similar(a, T, dims), $felt(T))
$fname(a::AbstractArray, T::Type, dims...) = fill!(similar(a,T,dims...), $felt(T))
$fname(a::AbstractArray, T::Type=eltype(a)) = fill!(similar(a,T), $felt(T))

$fname(T::Type, dims::Tuple) = fill!(Array{T}(Dims(dims)...), $felt(T))
Copy link
Copy Markdown
Member

@stevengj stevengj Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for splatting here; you can just do fill!(Array{T}(Dims(dims)), $felt(T)) I think?

$fname(dims::Tuple) = ($fname)(Float64, dims)
$fname(T::Type, dims...) = $fname(T, dims)
$fname(dims...) = $fname(dims)
end
end

Expand Down