Conversation
tkelman
left a comment
There was a problem hiding this comment.
when we get doctests running regularly we can have those run in permissive mode except for releases, right?
I'm going to try see if I can get doctests running on each build in this PR. That should stop things like backtrace line numbers becoming stale. There's a 265-related fix in Documenter that I need to tag first though that's blocking running |
|
I think line numbers will get annoying to keep changing on master, we can ignore those until release branches. Maybe we should take "running doctests on CI" one step at a time to see how it works day to day? |
|
Ok, small steps are fine too. I'll just push the doc version bump and a couple of doctest fixes here, but leave turning on doctests for another time. |
JuliaLang#19635 merged two docstrings for each of `zeros` and `ones` in a single docstring each. This changes the signatures in the stdlib file to reflect that change.
This avoids an error that occurs when documentaion dep versions have been updated, but `Pkg.update` hasn't been called which results in `Pkg.resolve` not being able to find suitable package versions.
This should make travis builds on PRs fail when changes are made that cause `doc/make.jl` to raise warnings that need to be addressed prior to merging.
Fixes docs builds on 32bit platforms.
0e19b4a to
90003ad
Compare
stdlib/arrays.mdfor changes to docstring signatures made in Zeros #19635;Pkg.resolveandPkg.updateto hopefully solve an error encountered by @kshyatt;strict = trueto change doc errors/warnings prior to merging PRs.