WIP: LibGit2 support for Git credential helpers#20725
Conversation
|
Is this actually release blocking for 0.6? If not, 1.0 might be the more appropriate milestone. (cc @tkelman) |
|
I can see the argument for not having this be blocking for 0.6. However, this work does include numerous fixes and tests I would like to see included in a 0.6 release. Additionally, I require the git credential helper feature for running a GitLab CI with support private package dependencies on Julia 0.6 |
|
If the git credential helper relies on command-line git, then I don't think it should live in base. Can you separate the fixes, tests, and features here? This is a pretty big PR to be opening as we're basically one build-fix away from feature freeze. |
Found a bug where scp-like syntax would interpret a path as a port.
Changes include: - Use LibGit2 callback payload to keep track of state - Avoid sending invalid credentials multiple times to remote servers - Allowing accept or reject of cached credentials - Testing framework which automates credential prompt responses and does not require external servers
f3bf5b0 to
b0bf68d
Compare
|
I broke up the PR into smaller commits. Unfortunately GitHub isn't showing the commits in the right order. Here's a listing in the correct order:
|
|
I'll be breaking this PR up into multiple PRs to make things faster and easier to review. |
|
Removing 0.6.0 milestone as this is no longer critical. Details in #20769 |
|
With the merger of #23824 this PR can now be retired. |
Refactored the LibGit2 credential callback to add support for Git credential helpers. Since the credential callback code was mostly untested I also wrote tests for this code and fixed several issues that were discovered by the new tests. Changes include:
^D) to abort credential promptAdditional work to do:
Make tests compatible with WindowsDisable tests for Windowsgitisn't installed^D