Skip to content

don't print field names in static_show of structs#40652

Closed
JeffBezanson wants to merge 1 commit intomasterfrom
jb/fix38902
Closed

don't print field names in static_show of structs#40652
JeffBezanson wants to merge 1 commit intomasterfrom
jb/fix38902

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

We don't use this as the default format for show, so it seems like a pretty spurious (even if rare) reason for a precompile statement not to work. Of course it still won't be 100% right, but is much more likely to work.

fixes #38902

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented May 4, 2021

This would be a usability regression to me. It also doesn't fix #38902, since it isn't 100% right, though it does some common cases of that.

@JeffBezanson
Copy link
Copy Markdown
Member Author

Obvious suggestion: only change it for printing precompile statements?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented May 6, 2021

Perhaps, though in general this is supposed to be a serializer/deserializer, not a deparse/eval function, so I think precompile just needs to handle these better (FWIW, in contrib/generate_precompile, we are already not calling eval directly but instead are starting to deserialize them, because it is more reliable and addresses some other corner cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precompile statements invalid for value types

3 participants