don't print field names in static_show of structs#40652
Closed
JeffBezanson wants to merge 1 commit intomasterfrom
Closed
don't print field names in static_show of structs#40652JeffBezanson wants to merge 1 commit intomasterfrom
JeffBezanson wants to merge 1 commit intomasterfrom
Conversation
Sacha0
approved these changes
Apr 28, 2021
Member
|
This would be a usability regression to me. It also doesn't fix #38902, since it isn't 100% right, though it does some common cases of that. |
Member
Author
|
Obvious suggestion: only change it for printing precompile statements? |
Member
|
Perhaps, though in general this is supposed to be a serializer/deserializer, not a deparse/eval function, so I think precompile just needs to handle these better (FWIW, in contrib/generate_precompile, we are already not calling eval directly but instead are starting to deserialize them, because it is more reliable and addresses some other corner cases) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use this as the default format for
show, so it seems like a pretty spurious (even if rare) reason for a precompile statement not to work. Of course it still won't be 100% right, but is much more likely to work.fixes #38902