Skip to content

Add codecov token#129

Merged
stevengj merged 1 commit intomasterfrom
dw/codecov_token
Feb 6, 2024
Merged

Add codecov token#129
stevengj merged 1 commit intomasterfrom
dw/codecov_token

Conversation

@devmotion
Copy link
Copy Markdown
Member

This PR fixes codecov integration (see the discussion in #128). @DilumAluthge added an orgwide codecov token for JuliaMath (AFAIK) and hence this should work without any additional changes or new Github secrets in AbstractFFTs.

Closes #128.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f58b5) 94.83% compared to head (5a4636e) 94.83%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files           5        5           
  Lines         445      445           
=======================================
  Hits          422      422           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Copy Markdown
Member

jishnub commented Feb 6, 2024

Hijacking this thread: it would be great to add similar org-level tokens for other orgs like JuliaArrays and JuliaLinearAlgebra. I wonder if @DilumAluthge has admin access to these?

@DilumAluthge
Copy link
Copy Markdown
Member

I can take care of JuliaLinearAlgebra. I don't have access to JuliaArrays, but I'll reach out to some of the owners of that org.

@jishnub
Copy link
Copy Markdown
Member

jishnub commented Feb 6, 2024

I've managed to get both of these done after Viral gave me the permission. Thanks a lot anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants