Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 5 5
Lines 445 445
=======================================
Hits 422 422
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Member
|
Hijacking this thread: it would be great to add similar org-level tokens for other orgs like |
Member
|
I can take care of |
Member
|
I've managed to get both of these done after Viral gave me the permission. Thanks a lot anyway! |
This was referenced Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes codecov integration (see the discussion in #128). @DilumAluthge added an orgwide codecov token for JuliaMath (AFAIK) and hence this should work without any additional changes or new Github secrets in AbstractFFTs.
Closes #128.