Add support for Normed construction from Rational (Fixes #157)#169
Add support for Normed construction from Rational (Fixes #157)#169kimikage merged 1 commit intoJuliaMath:masterfrom
Normed construction from Rational (Fixes #157)#169Conversation
This also fixes the overflow problem with `Fixed` construction from `Rational`.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 88.64% 88.32% -0.32%
==========================================
Files 5 5
Lines 370 377 +7
==========================================
+ Hits 328 333 +5
- Misses 42 44 +2
Continue to review full report at Codecov.
|
|
I chose the input range just because it is looser (i.e. it has a low impact of the change). |
|
Of course, anyone's opinion is fine. I'm worried about setting the specifications against the thoughts of "silent" users. However, I also think that this is not a good place for consensus building. |
|
I cannot see the negative effect unless we release it. I'm concentrating my efforts on releasing v0.8.0. |
This also fixes the overflow problem with
Fixedconstruction fromRational. (Fixes #157)Note the input range that
Fixedallows (cf. issue #156).