Merged
Conversation
This was
linked to
issues
Jul 24, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 89.21% 87.84% -1.37%
==========================================
Files 6 6
Lines 482 469 -13
==========================================
- Hits 430 412 -18
- Misses 52 57 +5
Continue to review full report at Codecov.
|
timholy
approved these changes
Aug 6, 2020
Member
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
Sorry I didn't notice this earlier. Very nice improvement. Thanks for adding @inferred to the tests.
This makes the promotion rules for `Fixed` consistent with the rules used within `Normed`: - `Fixed` and `Integer` are promoted to `floattype` - `Fixed` and `AbstractFloat` are promoted to `floattype` with sufficient precision This adds the rule: - `Fixed` and `Normed` are promoted to `floattype` This also stops using `@generated` function.
kimikage
force-pushed
the
promotion_rule
branch
from
0c43ac8 to
9c52516
Compare
Collaborator
Author
|
I ran I'm not sure how |
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192, #126, #78
This makes the promotion rules for
Fixedconsistent with the rules used withinNormed:FixedandIntegerare promoted tofloattypeFixedandAbstractFloatare promoted tofloattypewith sufficient precisionThis adds the rule:
FixedandNormedare promoted tofloattypeThis also stops using
@generatedfunction.